Skip to content

Commit 0feb855

Browse files
matifalimatifali
authored
fix: revert back to curl in deply-pr.yaml (#8729)
1 parent 733ae50 commit 0feb855

File tree

1 file changed

+18
-23
lines changed

1 file changed

+18
-23
lines changed

‎.github/workflows/pr-deploy.yaml

+18-23
Original file line numberDiff line numberDiff line change
@@ -25,32 +25,30 @@ jobs:
2525
pr_commented:
2626
if: (github.event_name == 'issue_comment' && contains(github.event.comment.body, '/deploy-pr') && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'COLLABORATOR' || github.event.comment.author_association == 'OWNER')) || github.event_name == 'workflow_dispatch'
2727
outputs:
28-
PR_NUMBER: ${{ steps.pr_number.outputs.PR_NUMBER }}
29-
PR_TITLE: ${{ steps.pr_number.outputs.PR_TITLE }}
30-
PR_URL: ${{ steps.pr_number.outputs.PR_URL }}
31-
PR_BRANCH: ${{ steps.pr_number.outputs.PR_BRANCH }}
28+
PR_NUMBER: ${{ steps.pr_info.outputs.PR_NUMBER }}
29+
PR_TITLE: ${{ steps.pr_info.outputs.PR_TITLE }}
30+
PR_URL: ${{ steps.pr_info.outputs.PR_URL }}
31+
PR_BRANCH: ${{ steps.pr_info.outputs.PR_BRANCH }}
3232
CODER_BASE_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_BASE_IMAGE_TAG }}
3333
CODER_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_IMAGE_TAG }}
3434

3535
runs-on: "ubuntu-latest"
3636
steps:
3737
- name: Get PR number, title, and branch name
38-
id: pr_number
38+
id: pr_info
3939
run: |
40-
set -e pipefail
41-
if [[ ${{ github.event_name }} == 'workflow_dispatch' ]]; then
40+
set -euxo pipefail
41+
if [[ ${{ github.event_name }} == "workflow_dispatch" ]]; then
4242
PR_NUMBER=${{ github.event.inputs.pr_number }}"
4343
else
4444
PR_NUMBER=${{ github.event.issue.number }}"
4545
fi
46-
PR_TITLE=$(gh pr view $PR_NUMBER --json title | jq -r '.title')
47-
PR_BRANCH=$(gh pr view $PR_NUMBER --json headRefName | jq -r '.headRefName')
46+
PR_TITLE=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" https://api.github.com/repos/coder/coder/pulls/$PR_NUMBER | jq -r '.title')
47+
PR_BRANCH=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" https://api.github.com/repos/coder/coder/pulls/$PR_NUMBER | jq -r '.head.ref')
4848
echo "PR_URL=https://github.com/coder/coder/pull/$PR_NUMBER" >> $GITHUB_OUTPUT
4949
echo "PR_NUMBER=$PR_NUMBER" >> $GITHUB_OUTPUT
5050
echo "PR_TITLE=$PR_TITLE" >> $GITHUB_OUTPUT
5151
echo "PR_BRANCH=$PR_BRANCH" >> $GITHUB_OUTPUT
52-
env:
53-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5452
5553
- name: Set required tags
5654
id: set_tags
@@ -59,27 +57,27 @@ jobs:
5957
echo "CODER_BASE_IMAGE_TAG=$CODER_BASE_IMAGE_TAG" >> $GITHUB_OUTPUT
6058
echo "CODER_IMAGE_TAG=$CODER_IMAGE_TAG" >> $GITHUB_OUTPUT
6159
env:
62-
CODER_BASE_IMAGE_TAG: ghcr.io/coder/coder-preview-base:pr${{ steps.pr_number.outputs.PR_NUMBER }}
63-
CODER_IMAGE_TAG: ghcr.io/coder/coder-preview:pr${{ steps.pr_number.outputs.PR_NUMBER }}
60+
CODER_BASE_IMAGE_TAG: ghcr.io/coder/coder-preview-base:pr${{ steps.pr_info.outputs.PR_NUMBER }}
61+
CODER_IMAGE_TAG: ghcr.io/coder/coder-preview:pr${{ steps.pr_info.outputs.PR_NUMBER }}
6462

6563
- name: Comment on PR
6664
id: comment_id
6765
uses: peter-evans/create-or-update-comment@v3
6866
with:
69-
issue-number: ${{ steps.pr_number.outputs.PR_NUMBER }}
67+
issue-number: ${{ steps.pr_info.outputs.PR_NUMBER }}
7068
body: |
71-
:rocket: Deploying PR ${{ steps.pr_number.outputs.PR_NUMBER }} ...
69+
:rocket: Deploying PR ${{ steps.pr_info.outputs.PR_NUMBER }} ...
7270
:warning: This deployment will be deleted when the PR is closed.
73-
reactions: "-1"
71+
reactions: "+1"
7472

7573
build:
7674
needs: pr_commented
7775
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
7876
env:
7977
DOCKER_CLI_EXPERIMENTAL: "enabled"
80-
CODER_IMAGE_TAG: ${{ needs.pr_commented.outputs.coder_image_tag }}
81-
PR_NUMBER: ${{ needs.pr_commented.outputs.pr_number }}
82-
PR_BRANCH: ${{ needs.pr_commented.outputs.pr_branch }}
78+
CODER_IMAGE_TAG: ${{ needs.pr_commented.outputs.CODER_IMAGE_TAG }}
79+
PR_NUMBER: ${{ needs.pr_commented.outputs.PR_NUMBER }}
80+
PR_BRANCH: ${{ needs.pr_commented.outputs.PR_BRANCH }}
8381
steps:
8482
- name: Checkout
8583
uses: actions/checkout@v3
@@ -239,10 +237,7 @@ jobs:
239237
:heavy_check_mark: Deployed PR ${{ env.PR_NUMBER }} successfully.
240238
:rocket: Access the deployment link [here](${{ env.PR_DEPLOYMENT_ACCESS_URL }}).
241239
:warning: This deployment will be deleted when the PR is closed.
242-
reactions: |
243-
+1
244-
rocket
245-
reactions-edit-mode: replace
240+
reactions: rocket
246241

247242
env:
248243
PR_DEPLOYMENT_ACCESS_URL: "https://pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}"

0 commit comments

Comments
 (0)