WIP

mtojek · mtojek · commit 1118d67f8199 · 2024-09-04T12:18:01.000Z
diff --git a/coderd/database/migrations/000249_email_reports.up.sql b/coderd/database/migrations/000249_email_reports.up.sql
@@ -10,7 +10,7 @@ Template {{.Labels.template_display_name}} has failed to build {{.Data.failed_bu
   **{{$version.template_version_name}}** failed {{$version.failed_count}} time{{if gt $version.failed_count 1}}s{{end}}:
   {{range $build := $version.failed_builds}}
     * [{{$build.workspace_owner_username}} / {{$build.workspace_name}} / #{{$build.build_number}}]({{base_url}}/@{{$build.workspace_owner_username}}/{{$build.workspace_name}}/builds/{{$build.build_number}})
-  {{end}}
+  {{- end}}
 {{end}}
 
 We recommend reviewing these issues to ensure future builds are successful.',
diff --git a/coderd/notifications/notifications_test.go b/coderd/notifications/notifications_test.go
@@ -51,7 +51,7 @@ import (
 )
 
 // updateGoldenFiles is a flag that can be set to update golden files.
-var updateGoldenFiles = flag.Bool("update", true, "Update golden files")
+var updateGoldenFiles = flag.Bool("update", false, "Update golden files")
 
 func TestMain(m *testing.M) {
 	goleak.VerifyTestMain(m)
@@ -861,7 +861,7 @@ func TestNotificationTemplatesCanRender(t *testing.T) {
 						{
 							"template_version_name": "bobby-template-version-1",
 							"failed_count":          3,
-							"builds": []map[string]any{
+							"failed_builds": []map[string]any{
 								{
 									"workspace_owner_username": "mtojek",
 									"workspace_name":           "workspace-1",
@@ -882,7 +882,7 @@ func TestNotificationTemplatesCanRender(t *testing.T) {
 						{
 							"template_version_name": "bobby-template-version-2",
 							"failed_count":          1,
-							"builds": []map[string]any{
+							"failed_builds": []map[string]any{
 								{
 									"workspace_owner_username": "ben",
 									"workspace_name":           "cool-workspace",
diff --git a/coderd/notifications/testdata/rendered-templates/TemplateWorkspaceBuildSummary-body.md.golden b/coderd/notifications/testdata/rendered-templates/TemplateWorkspaceBuildSummary-body.md.golden
@@ -7,9 +7,13 @@ Template Bobby First Template has failed to build 4/55 times over the last week
 
   **bobby-template-version-1** failed 3 times:
   
+    * [mtojek / workspace-1 / #1234](http://test.com/@mtojek/workspace-1/builds/1234)
+    * [johndoe / my-workspace-3 / #5678](http://test.com/@johndoe/my-workspace-3/builds/5678)
+    * [jack / workwork / #774](http://test.com/@jack/workwork/builds/774)
 
   **bobby-template-version-2** failed 1 time:
   
+    * [ben / cool-workspace / #8888](http://test.com/@ben/cool-workspace/builds/8888)
 
 
 We recommend reviewing these issues to ensure future builds are successful.

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ import (`
`51`	`51`	`)`
`52`	`52`
`53`	`53`	`// updateGoldenFiles is a flag that can be set to update golden files.`
`54`		`-var updateGoldenFiles = flag.Bool("update", true, "Update golden files")`
	`54`	`+var updateGoldenFiles = flag.Bool("update", false, "Update golden files")`
`55`	`55`
`56`	`56`	`func TestMain(m *testing.M) {`
`57`	`57`	`goleak.VerifyTestMain(m)`
`@@ -861,7 +861,7 @@ func TestNotificationTemplatesCanRender(t *testing.T) {`
`861`	`861`	`{`
`862`	`862`	`"template_version_name": "bobby-template-version-1",`
`863`	`863`	`"failed_count": 3,`
`864`		`- "builds": []map[string]any{`
	`864`	`+ "failed_builds": []map[string]any{`
`865`	`865`	`{`
`866`	`866`	`"workspace_owner_username": "mtojek",`
`867`	`867`	`"workspace_name": "workspace-1",`
`@@ -882,7 +882,7 @@ func TestNotificationTemplatesCanRender(t *testing.T) {`
`882`	`882`	`{`
`883`	`883`	`"template_version_name": "bobby-template-version-2",`
`884`	`884`	`"failed_count": 1,`
`885`		`- "builds": []map[string]any{`
	`885`	`+ "failed_builds": []map[string]any{`
`886`	`886`	`{`
`887`	`887`	`"workspace_owner_username": "ben",`
`888`	`888`	`"workspace_name": "cool-workspace",`