only screenshot in verbose mode

johnstcn · johnstcn · commit 11e2833b8b60 · 2023-10-10T22:00:07.000Z
diff --git a/cli/exp_scaletest.go b/cli/exp_scaletest.go
@@ -1158,6 +1158,11 @@ func (r *RootCmd) scaletestDashboard() *clibase.Cmd {
 					Headless: headless,
 					RandIntn: rndGen.Intn,
 				}
+				// Only take a screenshot if we're in verbose mode.
+				// This could be useful for debugging, but it will blow up the disk.
+				if r.verbose {
+					config.Screenshot = dashboard.Screenshot
+				}
 				//nolint:gocritic
 				logger.Info(ctx, "runner config", slog.F("interval", interval), slog.F("jitter", jitter), slog.F("headless", headless), slog.F("trace", tracingEnabled))
 				if err := config.Validate(); err != nil {
diff --git a/scaletest/dashboard/chromedp.go b/scaletest/dashboard/chromedp.go
@@ -230,7 +230,7 @@ func visitMainPage(ctx context.Context, u *url.URL) error {
 	return chromedp.Run(ctx, chromedp.Navigate(u.String()))
 }
 
-func screenshot(ctx context.Context, name string) (string, error) {
+func Screenshot(ctx context.Context, name string) (string, error) {
 	var buf []byte
 	if err := chromedp.Run(ctx, chromedp.CaptureScreenshot(&buf)); err != nil {
 		return "", xerrors.Errorf("capture screenshot: %w", err)
diff --git a/scaletest/dashboard/run.go b/scaletest/dashboard/run.go
@@ -33,7 +33,7 @@ func NewRunner(client *codersdk.Client, metrics Metrics, cfg Config) *Runner {
 		cfg.ActionFunc = clickRandomElement
 	}
 	if cfg.Screenshot == nil {
-		cfg.Screenshot = screenshot
+		cfg.Screenshot = Screenshot
 	}
 	return &Runner{
 		client:  client,

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ func visitMainPage(ctx context.Context, u *url.URL) error {`
`230`	`230`	`return chromedp.Run(ctx, chromedp.Navigate(u.String()))`
`231`	`231`	`}`
`232`	`232`
`233`		`-func screenshot(ctx context.Context, name string) (string, error) {`
	`233`	`+func Screenshot(ctx context.Context, name string) (string, error) {`
`234`	`234`	`var buf []byte`
`235`	`235`	`if err := chromedp.Run(ctx, chromedp.CaptureScreenshot(&buf)); err != nil {`
`236`	`236`	`return "", xerrors.Errorf("capture screenshot: %w", err)`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func NewRunner(client codersdk.Client, metrics Metrics, cfg Config) Runner {`
`33`	`33`	`cfg.ActionFunc = clickRandomElement`
`34`	`34`	`}`
`35`	`35`	`if cfg.Screenshot == nil {`
`36`		`- cfg.Screenshot = screenshot`
	`36`	`+ cfg.Screenshot = Screenshot`
`37`	`37`	`}`
`38`	`38`	`return &Runner{`
`39`	`39`	`client: client,`