Skip to content

Commit 120bc4b

Browse files
refactor(site): Only show status after first edition (#6701)
1 parent 7e854ad commit 120bc4b

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

site/src/components/TemplateVersionEditor/TemplateVersionEditor.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
8989
const [createFileOpen, setCreateFileOpen] = useState(false)
9090
const [deleteFileOpen, setDeleteFileOpen] = useState<string>()
9191
const [renameFileOpen, setRenameFileOpen] = useState<string>()
92+
const [dirty, setDirty] = useState(false)
9293
const [activePath, setActivePath] = useState<string | undefined>(() =>
9394
findInitialFile(fileTree),
9495
)
@@ -139,11 +140,11 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
139140
previousVersion.current = templateVersion
140141
}, [templateVersion])
141142

142-
const [dirty, setDirty] = useState(false)
143143
const hasIcon = template.icon && template.icon !== ""
144144
const templateVersionSucceeded = templateVersion.job.status === "succeeded"
145145
const showBuildLogs = Boolean(buildLogs)
146146
const editorValue = getFileContent(activePath ?? "", fileTree) as string
147+
const firstTemplateVersionOnEditor = useRef(templateVersion)
147148

148149
useEffect(() => {
149150
window.dispatchEvent(new Event("resize"))
@@ -170,9 +171,12 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
170171
</div>
171172

172173
<div className={styles.topbarSides}>
173-
<div className={styles.buildStatus}>
174-
<TemplateVersionStatusBadge version={templateVersion} />
175-
</div>
174+
{/* Only start to show the build when a new template version is building */}
175+
{templateVersion.id !== firstTemplateVersionOnEditor.current.id && (
176+
<div className={styles.buildStatus}>
177+
<TemplateVersionStatusBadge version={templateVersion} />
178+
</div>
179+
)}
176180

177181
<Button
178182
title="Build template (Ctrl + Enter)"
@@ -387,7 +391,7 @@ const useStyles = makeStyles<
387391
{
388392
templateVersionSucceeded: boolean
389393
showBuildLogs: boolean
390-
deploymentBannerVisible: boolean
394+
deploymentBannerVisible?: boolean
391395
}
392396
>((theme) => ({
393397
root: {

0 commit comments

Comments
 (0)