fix leaked files

Emyrk · Emyrk · commit 13215d621fb2 · 2025-05-15T14:28:19.000-05:00
diff --git a/coderd/parameters.go b/coderd/parameters.go
@@ -120,7 +120,7 @@ func (api *API) handleDynamicParameters(rw http.ResponseWriter, r *http.Request,
 
 	if tf.CachedModuleFiles.Valid {
 		moduleFilesFS, err := api.FileCache.Acquire(fileCtx, tf.CachedModuleFiles.UUID)
-		defer api.FileCache.Release(fileID)
+		defer api.FileCache.Release(tf.CachedModuleFiles.UUID)
 		if err != nil {
 			httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{
 				Message: "Internal error fetching Terraform modules.",
diff --git a/codersdk/client.go b/codersdk/client.go
@@ -359,7 +359,7 @@ func (c *Client) Dial(ctx context.Context, path string, opts *websocket.DialOpti
 	}
 
 	conn, resp, err := websocket.Dial(ctx, u.String(), opts)
-	if resp.Body != nil {
+	if resp != nil && resp.Body != nil {
 		resp.Body.Close()
 	}
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ func (c Client) Dial(ctx context.Context, path string, opts websocket.DialOpti`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`conn, resp, err := websocket.Dial(ctx, u.String(), opts)`
`362`		`- if resp.Body != nil {`
	`362`	`+ if resp != nil && resp.Body != nil {`
`363`	`363`	`resp.Body.Close()`
`364`	`364`	`}`
`365`	`365`	`if err != nil {`