Skip to content

Commit 13360e2

Browse files
kylecarbskylecarbs
authored
fix: Insert provisioner job logs async (#185)
The context could be cancelled after a log is sent, which resulted in a failure. This prevent's that from occurring by using the background context.
1 parent d55231c commit 13360e2

File tree

3 files changed

+7
-23
lines changed

3 files changed

+7
-23
lines changed

‎coderd/provisionerdaemons.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,8 @@ func (server *provisionerdServer) UpdateJob(stream proto.DRPCProvisionerDaemon_U
305305
insertParams.Source = append(insertParams.Source, logSource)
306306
insertParams.Output = append(insertParams.Output, log.Output)
307307
}
308-
logs, err := server.Database.InsertProvisionerJobLogs(stream.Context(), insertParams)
308+
logs, err := server.Database.InsertProvisionerJobLogs(context.Background(), insertParams)
309309
if err != nil {
310-
server.Logger.Error(stream.Context(), "insert provisioner job logs", slog.Error(err))
311310
return xerrors.Errorf("insert job logs: %w", err)
312311
}
313312
data, err := json.Marshal(logs)

‎database/dump.sql

Lines changed: 6 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎database/models.go

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)