allow skipping outputs

Emyrk · Emyrk · commit 1336e2802cd8 · 2023-02-03T09:52:32.000-06:00
diff --git a/coderd/authzquery/methods_test.go b/coderd/authzquery/methods_test.go
@@ -146,10 +146,14 @@ MethodLoop:
 			outputs, err := splitResp(t, resp)
 			require.NoError(t, err, "method %q returned an error", testName)
 
-			// Also assert the required outputs
-			require.Equal(t, len(testCase.ExpectedOutputs), len(outputs), "method %q returned unexpected number of outputs", testName)
-			for i := range outputs {
-				require.Equal(t, testCase.ExpectedOutputs[i].Interface(), outputs[i].Interface(), "method %q returned unexpected output %d", testName, i)
+			// Some tests may not care about the outputs, so we only assert if
+			// they are provided.
+			if testCase.ExpectedOutputs != nil {
+				// Assert the required outputs
+				require.Equal(t, len(testCase.ExpectedOutputs), len(outputs), "method %q returned unexpected number of outputs", testName)
+				for i := range outputs {
+					require.Equal(t, testCase.ExpectedOutputs[i].Interface(), outputs[i].Interface(), "method %q returned unexpected output %d", testName, i)
+				}
 			}
 
 			found = true
diff --git a/coderd/authzquery/user_test.go b/coderd/authzquery/user_test.go
@@ -60,14 +60,16 @@ func (s *MethodTestSuite) TestUser() {
 		s.RunMethodTest(func(t *testing.T, db database.Store) MethodCase {
 			a := dbgen.User(t, db, database.User{})
 			b := dbgen.User(t, db, database.User{})
-			return methodCase(values(database.GetUsersParams{}), asserts(a, rbac.ActionRead, b, rbac.ActionRead))
+			return methodCase(values(database.GetUsersParams{}),
+				asserts(a, rbac.ActionRead, b, rbac.ActionRead),
+				values([]database.User{a, b}))
 		})
 	})
 	s.Run("GetUsersWithCount", func() {
 		s.RunMethodTest(func(t *testing.T, db database.Store) MethodCase {
 			a := dbgen.User(t, db, database.User{})
 			b := dbgen.User(t, db, database.User{})
-			return methodCase(values(database.GetUsersParams{}), asserts(a, rbac.ActionRead, b, rbac.ActionRead))
+			return methodCase(values(database.GetUsersParams{}), asserts(a, rbac.ActionRead, b, rbac.ActionRead), nil)
 		})
 	})
 	s.Run("GetUsersByIDs", func() {
