Skip to content

Commit 1545979

Browse files
authored
docs: 1. fix closing ) on projector examples 2.update jupyter section for slug config and removal of owner and workspace baseURL (#4920)
1 parent 641aacf commit 1545979

File tree

3 files changed

+10
-15
lines changed

3 files changed

+10
-15
lines changed

docs/ides/web-ides.md

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ projector:
139139

140140
- PyCharm
141141
([Docker](https://github.com/sharkymark/v2-templates/tree/main/docker-with-pycharm),
142-
[Kubernetes](https://github.com/sharkymark/v2-templates/tree/main/multi-projector-pycharm)
142+
[Kubernetes](https://github.com/sharkymark/v2-templates/tree/main/multi-projector-pycharm))
143143

144144
> You need to have a valid `~/.kube/config` on your Coder host and a namespace
145145
> on a Kubernetes cluster to use the Kubernetes pod template examples.
@@ -153,39 +153,34 @@ Configure your agent and `coder_app` like so to use Jupyter:
153153
```hcl
154154
data "coder_workspace" "me" {}
155155
156-
## The name of the app must always be equal to the "/apps/<name>"
157-
## string in the base_url. This caveat is unique to Jupyter.
158-
159-
locals {
160-
jupyter_base_path = "/@${data.coder_workspace.me.owner}/${data.coder_workspace.me.name}/apps/JupyterLab/"
161-
}
162-
163156
resource "coder_agent" "coder" {
164157
os = "linux"
165158
arch = "amd64"
166159
dir = "/home/coder"
167160
startup_script = <<-EOF
168161
pip3 install jupyterlab
169-
$HOME/.local/bin/jupyter lab --ServerApp.base_url=${local.jupyter_base_path} --ServerApp.token='' --ip='*'
162+
$HOME/.local/bin/jupyter lab --ServerApp.token='' --ip='*'
170163
EOF
171164
}
172165
173166
resource "coder_app" "jupyter" {
174167
agent_id = coder_agent.coder.id
175168
slug = "jupyter"
176169
display_name = "JupyterLab"
177-
url = "http://localhost:8888${local.jupyter_base_path}"
170+
url = "http://localhost:8888"
178171
icon = "/icon/jupyter.svg"
172+
share = "owner"
173+
subdomain = true
179174
180175
healthcheck {
181-
url = "http://localhost:8888${local.jupyter_base_path}"
176+
url = "http://localhost:8888/healthz"
182177
interval = 5
183178
threshold = 10
184179
}
185180
}
186181
```
187182

188-
![JupyterLab in Coder](../images/jupyterlab-port-forward.png)
183+
![JupyterLab in Coder](../images/jupyter-on-docker.png)
189184

190185

191186
### RStudio
@@ -218,7 +213,7 @@ resource "coder_app" "rstudio" {
218213
url = "http://localhost:8787/healthz"
219214
interval = 3
220215
threshold = 10
221-
}
216+
}
222217
}
223218
```
224219

@@ -254,7 +249,7 @@ resource "coder_app" "airflow" {
254249
url = "http://localhost:8080/healthz"
255250
interval = 10
256251
threshold = 60
257-
}
252+
}
258253
}
259254
```
260255

@@ -265,4 +260,4 @@ resource "coder_app" "airflow" {
265260
If you prefer to run web IDEs in localhost, you can port forward using
266261
[SSH](../ides.md#ssh) or the Coder CLI `port-forward` sub-command. Some web IDEs
267262
may not support URL base path adjustment so port forwarding is the only
268-
approach.
263+
approach.

docs/images/jupyter-on-docker.png

261 KB
Loading
-367 KB
Binary file not shown.

0 commit comments

Comments
 (0)