review notes

SasSwart · SasSwart · commit 176051a52bf7 · 2025-01-09T10:26:53.000Z
diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go
@@ -2321,10 +2321,6 @@ func TestGetUserStatusCountsOverTime(t *testing.T) {
 						name:   "Suspended Only",
 						status: database.UserStatusSuspended,
 					},
-					// {
-					// 	name:   "Deleted Only",
-					// 	status: database.UserStatusDeleted,
-					// },
 				}
 
 				for _, tc := range testCases {
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/insights.sql b/coderd/database/queries/insights.sql
@@ -873,7 +873,7 @@ ranked_status_change_per_user_per_date AS (
 	LEFT JOIN relevant_status_changes rsc1 ON rsc1.changed_at <= d.date
 )
 SELECT
-	date,
+	rscpupd.date,
 	statuses.new_status AS status,
 	COUNT(rscpupd.user_id) FILTER (
 		WHERE rscpupd.rn = 1
diff --git a/coderd/insights.go b/coderd/insights.go
@@ -329,6 +329,10 @@ func (api *API) insightsUserStatusCountsOverTime(rw http.ResponseWriter, r *http
 		EndTime:   nextHourInLoc,
 	})
 	if err != nil {
+		if httpapi.IsUnauthorizedError(err) {
+			httpapi.Forbidden(rw)
+			return
+		}
 		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
 			Message: "Internal error fetching user status counts over time.",
 			Detail:  err.Error(),
@@ -342,9 +346,6 @@ func (api *API) insightsUserStatusCountsOverTime(rw http.ResponseWriter, r *http
 
 	for _, row := range rows {
 		status := codersdk.UserStatus(row.Status)
-		if _, ok := resp.StatusCounts[status]; !ok {
-			resp.StatusCounts[status] = make([]codersdk.UserStatusChangeCount, 0)
-		}
 		resp.StatusCounts[status] = append(resp.StatusCounts[status], codersdk.UserStatusChangeCount{
 			Date:  row.Date,
 			Count: row.Count,

Original file line number	Diff line number	Diff line change
`@@ -873,7 +873,7 @@ ranked_status_change_per_user_per_date AS (`
`873`	`873`	`LEFT JOIN relevant_status_changes rsc1 ON rsc1.changed_at <= d.date`
`874`	`874`	`)`
`875`	`875`	`SELECT`
`876`		`- date,`
	`876`	`+ rscpupd.date,`
`877`	`877`	`statuses.new_status AS status,`
`878`	`878`	`COUNT(rscpupd.user_id) FILTER (`
`879`	`879`	`WHERE rscpupd.rn = 1`