Skip to content

Commit 1773c24

Browse files
committed
failedConnectionsTotal
1 parent 90b351d commit 1773c24

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

agent/agentssh/agentssh.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func NewServer(ctx context.Context, logger slog.Logger, prometheusRegistry *prom
113113
},
114114
ConnectionFailedCallback: func(_ net.Conn, err error) {
115115
s.logger.Warn(ctx, "ssh connection failed", slog.Error(err))
116-
metrics.connectionFailedCallback.Add(1)
116+
metrics.failedConnectionsTotal.Add(1)
117117
},
118118
Handler: s.sessionHandler,
119119
HostSigners: []ssh.Signer{randomSigner},

agent/agentssh/metrics.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
)
88

99
type sshServerMetrics struct {
10-
connectionFailedCallback prometheus.Counter
10+
failedConnectionsTotal prometheus.Counter
1111

1212
// SFTP
1313
sftpHandler prometheus.Counter
@@ -47,10 +47,10 @@ type sessionMetricsObject struct {
4747
type sessionMetrics map[string]sessionMetricsObject
4848

4949
func newSSHServerMetrics(registerer prometheus.Registerer) *sshServerMetrics {
50-
connectionFailedCallback := prometheus.NewCounter(prometheus.CounterOpts{
51-
Namespace: "agent", Subsystem: "ssh_server", Name: "connection_failed_callback",
50+
failedConnectionsTotal := prometheus.NewCounter(prometheus.CounterOpts{
51+
Namespace: "agent", Subsystem: "ssh_server", Name: "failed_connections_total",
5252
})
53-
registerer.MustRegister(connectionFailedCallback)
53+
registerer.MustRegister(failedConnectionsTotal)
5454

5555
sftpHandler := prometheus.NewCounter(prometheus.CounterOpts{
5656
Namespace: "agent", Subsystem: "ssh_server", Name: "sftp_handler",
@@ -80,12 +80,12 @@ func newSSHServerMetrics(registerer prometheus.Registerer) *sshServerMetrics {
8080
sessions := newSessionMetrics(registerer)
8181

8282
return &sshServerMetrics{
83-
connectionFailedCallback: connectionFailedCallback,
84-
sftpHandler: sftpHandler,
85-
sftpServerError: sftpServerError,
86-
x11HostnameError: x11HostnameError,
87-
x11SocketDirError: x11SocketDirError,
88-
x11XauthorityError: x11XauthorityError,
83+
failedConnectionsTotal: failedConnectionsTotal,
84+
sftpHandler: sftpHandler,
85+
sftpServerError: sftpServerError,
86+
x11HostnameError: x11HostnameError,
87+
x11SocketDirError: x11SocketDirError,
88+
x11XauthorityError: x11XauthorityError,
8989

9090
sessions: sessions,
9191
}

0 commit comments

Comments
 (0)