Skip to content

Commit 18022ba

Browse files
committed
Remove legacy notify
1 parent 8933b49 commit 18022ba

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

cli/cliui/gitauth_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package cliui_test
22

33
import (
44
"context"
5-
"net/url"
65
"sync/atomic"
76
"testing"
87
"time"
@@ -33,7 +32,7 @@ func TestGitAuth(t *testing.T) {
3332
ID: "github",
3433
Type: codersdk.GitProviderGitHub,
3534
Authenticated: fetched.Load(),
36-
AuthenticateURL: "https://example.com/gitauth/github?redirect=" + url.QueryEscape("/gitauth?notify"),
35+
AuthenticateURL: "https://example.com/gitauth/github",
3736
}}, nil
3837
},
3938
FetchInterval: time.Millisecond,

coderd/templateversions.go

-8
Original file line numberDiff line numberDiff line change
@@ -320,14 +320,6 @@ func (api *API) templateVersionGitAuth(rw http.ResponseWriter, r *http.Request)
320320
})
321321
return
322322
}
323-
query := redirectURL.Query()
324-
// The frontend uses a BroadcastChannel to notify listening pages for
325-
// Git auth updates if the "notify" query parameter is set.
326-
//
327-
// It's important we do this in the backend, because the same endpoint
328-
// is used for CLI authentication.
329-
query.Add("redirect", "/gitauth?notify")
330-
redirectURL.RawQuery = query.Encode()
331323

332324
provider := codersdk.TemplateVersionGitAuth{
333325
ID: config.ID,

0 commit comments

Comments
 (0)