use unbuffered channels for flush

johnstcn · johnstcn · commit 184af274bef2 · 2024-01-16T13:48:43.000Z
diff --git a/coderd/workspaceapps/apptest/apptest.go b/coderd/workspaceapps/apptest/apptest.go
@@ -147,7 +147,7 @@ func Run(t *testing.T, appHostIsPrimary bool, factory DeploymentFactory) {
 			require.NoError(t, err)
 			require.True(t, loc.Query().Has("message"))
 			require.True(t, loc.Query().Has("redirect"))
-			assertWorkspaceLastUsedAtUpdated(t, appDetails)
+			assertWorkspaceLastUsedAtNotUpdated(t, appDetails)
 		})
 
 		t.Run("LoginWithoutAuthOnProxy", func(t *testing.T) {
@@ -185,7 +185,7 @@ func Run(t *testing.T, appHostIsPrimary bool, factory DeploymentFactory) {
 			// request is getting stripped.
 			require.Equal(t, u.Path, redirectURI.Path+"/")
 			require.Equal(t, u.RawQuery, redirectURI.RawQuery)
-			assertWorkspaceLastUsedAtUpdated(t, appDetails)
+			assertWorkspaceLastUsedAtNotUpdated(t, appDetails)
 		})
 
 		t.Run("NoAccessShould404", func(t *testing.T) {
diff --git a/coderd/workspaceapps_test.go b/coderd/workspaceapps_test.go
@@ -262,7 +262,7 @@ func TestWorkspaceApps(t *testing.T) {
 			opts.AppHost = ""
 		}
 
-		statsFlushCh := make(chan chan<- struct{}, 1)
+		statsFlushCh := make(chan chan<- struct{})
 		opts.StatsCollectorOptions.Flush = statsFlushCh
 		flushStats := func() {
 			flushDone := make(chan struct{})
diff --git a/enterprise/wsproxy/wsproxy_test.go b/enterprise/wsproxy/wsproxy_test.go
@@ -442,9 +442,9 @@ func TestWorkspaceProxyWorkspaceApps(t *testing.T) {
 			"*",
 		}
 
-		proxyFlushCh := make(chan chan<- struct{}, 1)
+		proxyFlushCh := make(chan chan<- struct{})
 		flushStats := func() {
-			proxyFlushDone := make(chan struct{}, 1)
+			proxyFlushDone := make(chan struct{})
 			proxyFlushCh <- proxyFlushDone
 			<-proxyFlushDone
 		}

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ func TestWorkspaceApps(t *testing.T) {`
`262`	`262`	`opts.AppHost = ""`
`263`	`263`	`}`
`264`	`264`
`265`		`- statsFlushCh := make(chan chan<- struct{}, 1)`
	`265`	`+ statsFlushCh := make(chan chan<- struct{})`
`266`	`266`	`opts.StatsCollectorOptions.Flush = statsFlushCh`
`267`	`267`	`flushStats := func() {`
`268`	`268`	`flushDone := make(chan struct{})`
Original file line number	Diff line number	Diff line change
`@@ -442,9 +442,9 @@ func TestWorkspaceProxyWorkspaceApps(t *testing.T) {`
`442`	`442`	`"*",`
`443`	`443`	`}`
`444`	`444`
`445`		`- proxyFlushCh := make(chan chan<- struct{}, 1)`
	`445`	`+ proxyFlushCh := make(chan chan<- struct{})`
`446`	`446`	`flushStats := func() {`
`447`		`- proxyFlushDone := make(chan struct{}, 1)`
	`447`	`+ proxyFlushDone := make(chan struct{})`
`448`	`448`	`proxyFlushCh <- proxyFlushDone`
`449`	`449`	`<-proxyFlushDone`
`450`	`450`	`}`