Fix linting

Emyrk · Emyrk · commit 18e52476872c · 2022-06-09T23:17:52.000-05:00
diff --git a/coderd/httpapi/queryparams_test.go b/coderd/httpapi/queryparams_test.go
@@ -6,9 +6,10 @@ import (
 	"net/url"
 	"testing"
 
-	"github.com/coder/coder/coderd/httpapi"
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/coderd/httpapi"
 )
 
 type queryParamTestCase[T any] struct {
diff --git a/coderd/httpapi/search.go b/coderd/httpapi/search.go
@@ -59,13 +59,13 @@ func splitElements(query string, delimiter rune) []string {
 			quoted = !quoted
 		case delimiter:
 			if quoted {
-				current.WriteRune(c)
+				_, _ = current.WriteRune(c)
 			} else {
 				parts = append(parts, current.String())
 				current = strings.Builder{}
 			}
 		default:
-			current.WriteRune(c)
+			_, _ = current.WriteRune(c)
 		}
 	}
 	parts = append(parts, current.String())
diff --git a/coderd/httpapi/search_test.go b/coderd/httpapi/search_test.go
@@ -3,8 +3,9 @@ package httpapi_test
 import (
 	"testing"
 
-	"github.com/coder/coder/coderd/httpapi"
 	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/coderd/httpapi"
 )
 
 func TestSearchWorkspace(t *testing.T) {
@@ -117,7 +118,6 @@ func TestSearchWorkspace(t *testing.T) {
 				require.NoError(t, err, "expected no error")
 				require.Equal(t, c.Expected, values, "expected values")
 			}
-
 		})
 	}
 }
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -108,7 +108,7 @@ func (api *API) workspaces(rw http.ResponseWriter, r *http.Request) {
 	values, err := httpapi.WorkspaceSearchQuery(queryStr)
 	if err != nil {
 		httpapi.Write(rw, http.StatusBadRequest, httpapi.Response{
-			Message: "Invalid workspace search query",
+			Message: "Invalid workspace search query.",
 			Validations: []httpapi.Error{
 				{Field: "q", Detail: err.Error()},
 			},
@@ -123,7 +123,7 @@ func (api *API) workspaces(rw http.ResponseWriter, r *http.Request) {
 		// outside the query string.
 		if q.Has(k) {
 			httpapi.Write(rw, http.StatusBadRequest, httpapi.Response{
-				Message: fmt.Sprintf("Workspace filter %q cannot be set twice. In query params %q and %q", k, k, "q"),
+				Message: fmt.Sprintf("Workspace filter %q cannot be set twice. In query params %q and %q.", k, k, "q"),
 			})
 			return
 		}
@@ -152,7 +152,7 @@ func (api *API) workspaces(rw http.ResponseWriter, r *http.Request) {
 	if filter.OwnerUsername == "me" {
 		if !(filter.OwnerID == uuid.Nil || filter.OwnerID == apiKey.UserID) {
 			httpapi.Write(rw, http.StatusBadRequest, httpapi.Response{
-				Message: fmt.Sprintf("Cannot set both \"me\" in \"owner_name\" and use \"owner_id\""),
+				Message: fmt.Sprintf("Cannot set both \"me\" in \"owner_name\" and use \"owner_id\"."),
 			})
 			return
 		}

Original file line number	Diff line number	Diff line change
`@@ -59,13 +59,13 @@ func splitElements(query string, delimiter rune) []string {`
`59`	`59`	`quoted = !quoted`
`60`	`60`	`case delimiter:`
`61`	`61`	`if quoted {`
`62`		`- current.WriteRune(c)`
	`62`	`+ _, _ = current.WriteRune(c)`
`63`	`63`	`} else {`
`64`	`64`	`parts = append(parts, current.String())`
`65`	`65`	`current = strings.Builder{}`
`66`	`66`	`}`
`67`	`67`	`default:`
`68`		`- current.WriteRune(c)`
	`68`	`+ _, _ = current.WriteRune(c)`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`	`parts = append(parts, current.String())`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,9 @@ package httpapi_test`
`3`	`3`	`import (`
`4`	`4`	`"testing"`
`5`	`5`
`6`		`- "github.com/coder/coder/coderd/httpapi"`
`7`	`6`	`"github.com/stretchr/testify/require"`
	`7`	`+`
	`8`	`+ "github.com/coder/coder/coderd/httpapi"`
`8`	`9`	`)`
`9`	`10`
`10`	`11`	`func TestSearchWorkspace(t *testing.T) {`
`@@ -117,7 +118,6 @@ func TestSearchWorkspace(t *testing.T) {`
`117`	`118`	`require.NoError(t, err, "expected no error")`
`118`	`119`	`require.Equal(t, c.Expected, values, "expected values")`
`119`	`120`	`}`
`120`		`-`
`121`	`121`	`})`
`122`	`122`	`}`
`123`	`123`	`}`