Do not allow creation of not allowed extensions

BrunoQuaresma · BrunoQuaresma · commit 19d84a245896 · 2023-03-02T14:50:30.000Z
diff --git a/site/src/components/TemplateVersionEditor/FileDialog.tsx b/site/src/components/TemplateVersionEditor/FileDialog.tsx
@@ -3,6 +3,7 @@ import { ConfirmDialog } from "components/Dialogs/ConfirmDialog/ConfirmDialog"
 import { Stack } from "components/Stack/Stack"
 import { ChangeEvent, FC, useState } from "react"
 import Typography from "@material-ui/core/Typography"
+import { allowedExtensions, isAllowedFile } from "util/templateVersion"
 
 export const CreateFileDialog: FC<{
   onClose: () => void
@@ -24,6 +25,14 @@ export const CreateFileDialog: FC<{
       setError("File already exists")
       return
     }
+    if (!isAllowedFile(pathValue)) {
+      setError(
+        `This is not an allowed extension. Valid extensions are: ${allowedExtensions.join(
+          ", ",
+        )}.`,
+      )
+      return
+    }
     onConfirm(pathValue)
     setPathValue("")
   }
diff --git a/site/src/util/templateVersion.ts b/site/src/util/templateVersion.ts
@@ -23,7 +23,7 @@ export const getTemplateVersionFiles = async (
   return files
 }
 
-const allowedExtensions = ["tf", "md", "Dockerfile"]
+export const allowedExtensions = ["tf", "md", "Dockerfile"]
 
 export const isAllowedFile = (name: string) => {
   return allowedExtensions.some((ext) => name.endsWith(ext))

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export const getTemplateVersionFiles = async (`
`23`	`23`	`return files`
`24`	`24`	`}`
`25`	`25`
`26`		`-const allowedExtensions = ["tf", "md", "Dockerfile"]`
	`26`	`+export const allowedExtensions = ["tf", "md", "Dockerfile"]`
`27`	`27`
`28`	`28`	`export const isAllowedFile = (name: string) => {`
`29`	`29`	`return allowedExtensions.some((ext) => name.endsWith(ext))`