fix(agent): prevent metadata from being discarded if report is slow (#10386)

mafredri · web-flow · commit 1a2aea3a6be3 · 2023-10-23T17:02:54.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -536,6 +536,14 @@ func (a *agent) reportMetadataLoop(ctx context.Context) {
 			continue
 		case <-report:
 			if len(updatedMetadata) > 0 {
+				select {
+				case <-reportSemaphore:
+				default:
+					// If there's already a report in flight, don't send
+					// another one, wait for next tick instead.
+					continue
+				}
+
 				metadata := make([]agentsdk.Metadata, 0, len(updatedMetadata))
 				for key, result := range updatedMetadata {
 					metadata = append(metadata, agentsdk.Metadata{
@@ -545,14 +553,6 @@ func (a *agent) reportMetadataLoop(ctx context.Context) {
 					delete(updatedMetadata, key)
 				}
 
-				select {
-				case <-reportSemaphore:
-				default:
-					// If there's already a report in flight, don't send
-					// another one, wait for next tick instead.
-					continue
-				}
-
 				go func() {
 					ctx, cancel := context.WithTimeout(ctx, reportTimeout)
 					defer func() {
