close chan

f0ssel · f0ssel · commit 1b139e4697e3 · 2024-08-22T20:30:13.000Z
diff --git a/coderd/database/dbtestutil/driver.go b/coderd/database/dbtestutil/driver.go
@@ -73,3 +73,7 @@ func (d *Driver) Open(name string) (driver.Conn, error) {
 
 	return c.Connect(context.Background())
 }
+
+func (d *Driver) Close() {
+	close(d.Connections)
+}
diff --git a/coderd/database/pubsub/pubsub_test.go b/coderd/database/pubsub/pubsub_test.go
@@ -51,7 +51,7 @@ func TestPGPubsub_Metrics(t *testing.T) {
 	event := "test"
 	data := "testing"
 	messageChannel := make(chan []byte)
-	unsub0, err := uut.Subscribe(event, func(ctx context.Context, message []byte) {
+	unsub0, err := uut.Subscribe(event, func(_ context.Context, message []byte) {
 		messageChannel <- message
 	})
 	require.NoError(t, err)
@@ -140,9 +140,11 @@ func TestPGPubsubDriver(t *testing.T) {
 	require.NoError(t, err)
 	pubber, err := pubsub.New(ctx, logger, db, connectionURL)
 	require.NoError(t, err)
+	defer pubber.Close()
 
 	// use a connector that sends us the connections for the subber
 	subDriver := dbtestutil.NewDriver()
+	defer subDriver.Close()
 	tconn, err := subDriver.Connector(connectionURL)
 	require.NoError(t, err)
 	tcdb := sql.OpenDB(tconn)

Original file line number	Diff line number	Diff line change
`@@ -73,3 +73,7 @@ func (d *Driver) Open(name string) (driver.Conn, error) {`
`73`	`73`
`74`	`74`	`return c.Connect(context.Background())`
`75`	`75`	`}`
	`76`	`+`
	`77`	`+func (d *Driver) Close() {`
	`78`	`+ close(d.Connections)`
	`79`	`+}`