another one

aslilac · aslilac · commit 1b478affa8d3 · 2024-10-15T21:02:19.000Z
diff --git a/site/e2e/playwright.config.ts b/site/e2e/playwright.config.ts
@@ -70,6 +70,7 @@ export default defineConfig({
 	],
 	reporter: [["./reporter.ts"]],
 	use: {
+		actionTimeout: 5000, // 5 seconds
 		baseURL: `http://localhost:${coderPort}`,
 		video: "retain-on-failure",
 		...(wsEndpoint
diff --git a/site/e2e/tests/auditLogs.spec.ts b/site/e2e/tests/auditLogs.spec.ts
@@ -44,20 +44,24 @@ test("inspecting and filtering audit logs", async ({ page }) => {
 
 	// Filter by resource type
 	await page.getByText("All resource types").click();
-	await page.getByRole("menu").getByText("Workspace Build").click();
+	const workspaceBuildsOption = page.getByText("Workspace Build");
+	await workspaceBuildsOption.scrollIntoViewIfNeeded({ timeout: 5000 });
+	await workspaceBuildsOption.click();
 	// Our workspace build should be visible
 	await expect(page.getByText(startedWorkspaceMessage)).toBeVisible();
 	// Logins should no longer be visible
 	await expect(page.getByText(loginMessage)).not.toBeVisible();
 
 	// Clear filters, everything should be visible again
-	await page.getByLabel("Clear filter").click();
+	await page.getByLabel("Clear search").click();
 	await expect(page.getByText(startedWorkspaceMessage)).toBeVisible();
 	await expect(page.getByText(loginMessage)).toBeVisible();
 
 	// Filter by action type
 	await page.getByText("All actions").click();
-	await page.getByRole("menu").getByText("Login").click();
+	const loginOption = page.getByText("Login");
+	await loginOption.scrollIntoViewIfNeeded({ timeout: 5000 });
+	await loginOption.click();
 	// Logins should be visible
 	await expect(page.getByText(loginMessage)).toBeVisible();
 	// Our workspace build should no longer be visible
diff --git a/site/src/components/SearchField/SearchField.stories.tsx b/site/src/components/SearchField/SearchField.stories.tsx
@@ -40,6 +40,6 @@ export const ClearValue: Story = {
 	},
 	play: async ({ canvasElement }) => {
 		const canvas = within(canvasElement);
-		await userEvent.click(canvas.getByRole("button", { name: "Clear field" }));
+		await userEvent.click(canvas.getByRole("button", { name: "Clear search" }));
 	},
 };
diff --git a/site/src/components/SearchField/SearchField.tsx b/site/src/components/SearchField/SearchField.tsx
@@ -40,15 +40,15 @@ export const SearchField: FC<SearchFieldProps> = ({
 				),
 				endAdornment: value !== "" && (
 					<InputAdornment position="end">
-						<Tooltip title="Clear field">
+						<Tooltip title="Clear search">
 							<IconButton
 								size="small"
 								onClick={() => {
 									onChange("");
 								}}
 							>
 								<CloseIcon css={{ fontSize: 14 }} />
-								<span css={{ ...visuallyHidden }}>Clear field</span>
+								<span css={{ ...visuallyHidden }}>Clear search</span>
 							</IconButton>
 						</Tooltip>
 					</InputAdornment>
