fix: add details to API response on backend

brettkolodny · brettkolodny · commit 1b8cf2a85989 · 2025-02-21T19:57:52.000Z
diff --git a/coderd/httpapi/httpapi.go b/coderd/httpapi/httpapi.go
@@ -154,6 +154,7 @@ func ResourceNotFound(rw http.ResponseWriter) {
 func Forbidden(rw http.ResponseWriter) {
 	Write(context.Background(), rw, http.StatusForbidden, codersdk.Response{
 		Message: "Forbidden.",
+		Detail:  "You don't have permission to view this page. If you believe this is a mistake, please contact your administrator or try signing in with different credentials.",
 	})
 }
 
diff --git a/site/src/components/Alert/ErrorAlert.tsx b/site/src/components/Alert/ErrorAlert.tsx
@@ -24,10 +24,9 @@ export const ErrorAlert: FC<
 		if (status === 403) {
 			return (
 				<>
-					<AlertTitle>You don't have permission to view this page</AlertTitle>
+					<AlertTitle>{message}</AlertTitle>
 					<AlertDetail>
-						If you believe this is a mistake, please contact your administrator
-						or try signing in with different credentials.{" "}
+						{detail}{" "}
 						<Link href="/workspaces" className="w-fit">
 							Go to workspaces
 						</Link>
diff --git a/site/src/pages/CreateUserPage/CreateUserPage.test.tsx b/site/src/pages/CreateUserPage/CreateUserPage.test.tsx
@@ -4,8 +4,8 @@ import {
 	renderWithAuth,
 	waitForLoaderToBeRemoved,
 } from "testHelpers/renderHelpers";
-import { Language as FormLanguage } from "./Language";
 import { CreateUserPage } from "./CreateUserPage";
+import { Language as FormLanguage } from "./Language";
 
 const renderCreateUserPage = async () => {
 	renderWithAuth(<CreateUserPage />, {

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,7 @@ func ResourceNotFound(rw http.ResponseWriter) {`
`154`	`154`	`func Forbidden(rw http.ResponseWriter) {`
`155`	`155`	`Write(context.Background(), rw, http.StatusForbidden, codersdk.Response{`
`156`	`156`	`Message: "Forbidden.",`
	`157`	`+ Detail: "You don't have permission to view this page. If you believe this is a mistake, please contact your administrator or try signing in with different credentials.",`
`157`	`158`	`})`
`158`	`159`	`}`
`159`	`160`