Add comment in 'isTTY' function

bryphe-coder · bryphe-coder · commit 1bff2f1ebc89 · 2022-02-12T02:35:49.000Z
diff --git a/cli/login.go b/cli/login.go
@@ -44,7 +44,6 @@ func login() *cobra.Command {
 				return xerrors.Errorf("has initial user: %w", err)
 			}
 			if !hasInitialUser {
-				// TODO: Bryan - is this check correct on windows?
 				if !isTTY(cmd.InOrStdin()) {
 					return xerrors.New("the initial user cannot be created in non-interactive mode. use the API")
 				}
diff --git a/cli/root.go b/cli/root.go
@@ -5,6 +5,7 @@ import (
 	"io"
 	"net/url"
 	"os"
+	"runtime"
 	"strings"
 
 	"github.com/fatih/color"
@@ -109,6 +110,11 @@ func createConfig(cmd *cobra.Command) config.Root {
 // This accepts a reader to work with Cobra's "InOrStdin"
 // function for simple testing.
 func isTTY(reader io.Reader) bool {
+	// TODO(Bryan): Is there a reliable way to check this on windows?
+	if runtime.GOOS == "windows" {
+		return true
+	}
+
 	file, ok := reader.(*os.File)
 	if !ok {
 		return false

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ func login() *cobra.Command {`
`44`	`44`	`return xerrors.Errorf("has initial user: %w", err)`
`45`	`45`	`}`
`46`	`46`	`if !hasInitialUser {`
`47`		`- // TODO: Bryan - is this check correct on windows?`
`48`	`47`	`if !isTTY(cmd.InOrStdin()) {`
`49`	`48`	`return xerrors.New("the initial user cannot be created in non-interactive mode. use the API")`
`50`	`49`	`}`