cleanup

Emyrk · Emyrk · commit 1c998080592c · 2024-05-14T19:29:29.000-05:00
diff --git a/coderd/rbac/roles.go b/coderd/rbac/roles.go
@@ -592,11 +592,6 @@ func roleSplit(role string) (name string, orgID string, err error) {
 	return arr[0], "", nil
 }
 
-func Perm[T Objecter](f func(o T) []policy.Action) []policy.Action {
-	var t T
-	return f(t)
-}
-
 // Permissions is just a helper function to make building roles that list out resources
 // and actions a bit easier.
 func Permissions(perms map[string][]policy.Action) []Permission {
diff --git a/coderd/rbac/roles_test.go b/coderd/rbac/roles_test.go
@@ -56,7 +56,6 @@ func TestOwnerExec(t *testing.T) {
 	})
 }
 
-// TODO: add the SYSTEM to the MATRIX
 func TestRolePermissions(t *testing.T) {
 	t.Parallel()
 
diff --git a/support/support.go b/support/support.go
@@ -460,7 +460,7 @@ func Run(ctx context.Context, d *Deps) (*Bundle, error) {
 	authChecks := map[string]codersdk.AuthorizationCheck{
 		"Read DeploymentValues": {
 			Object: codersdk.AuthorizationObject{
-				ResourceType: codersdk.ResourceDeploymentValues,
+				ResourceType: codersdk.ResourceDeploymentConfig,
 			},
 			Action: string(policy.ActionRead),
 		},

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ func TestOwnerExec(t *testing.T) {`
`56`	`56`	`})`
`57`	`57`	`}`
`58`	`58`
`59`		`-// TODO: add the SYSTEM to the MATRIX`
`60`	`59`	`func TestRolePermissions(t *testing.T) {`
`61`	`60`	`t.Parallel()`
`62`	`61`