feat(site): remove experiment deployment_health_page

johnstcn · johnstcn · commit 1cac9eba0840 · 2024-01-11T13:18:55.000Z
diff --git a/codersdk/deployment.go b/codersdk/deployment.go
@@ -2077,20 +2077,15 @@ func (c *Client) BuildInfo(ctx context.Context) (BuildInfoResponse, error) {
 type Experiment string
 
 const (
-	// Deployment health page
-	ExperimentDeploymentHealthPage Experiment = "deployment_health_page"
-
-	// Add new experiments here!
-	// ExperimentExample Experiment = "example"
+// Add new experiments here!
+// ExperimentExample Experiment = "example"
 )
 
 // ExperimentsAll should include all experiments that are safe for
 // users to opt-in to via --experimental='*'.
 // Experiments that are not ready for consumption by all users should
 // not be included here and will be essentially hidden.
-var ExperimentsAll = Experiments{
-	ExperimentDeploymentHealthPage,
-}
+var ExperimentsAll = Experiments{}
 
 // Experiments is a list of experiments.
 // Multiple experiments may be enabled at the same time.
diff --git a/site/src/components/Dashboard/DeploymentBanner/DeploymentBanner.tsx b/site/src/components/Dashboard/DeploymentBanner/DeploymentBanner.tsx
@@ -3,18 +3,14 @@ import { useQuery } from "react-query";
 import { deploymentStats } from "api/queries/deployment";
 import { usePermissions } from "hooks/usePermissions";
 import { DeploymentBannerView } from "./DeploymentBannerView";
-import { useDashboard } from "../DashboardProvider";
 import { health } from "api/queries/debug";
 
 export const DeploymentBanner: FC = () => {
-  const dashboard = useDashboard();
   const permissions = usePermissions();
   const deploymentStatsQuery = useQuery(deploymentStats());
   const healthQuery = useQuery({
     ...health(),
-    enabled:
-      dashboard.experiments.includes("deployment_health_page") &&
-      permissions.viewDeploymentValues,
+    enabled: permissions.viewDeploymentValues,
   });
 
   if (!permissions.viewDeploymentValues || !deploymentStatsQuery.data) {
diff --git a/site/src/components/Dashboard/Navbar/Navbar.tsx b/site/src/components/Dashboard/Navbar/Navbar.tsx
@@ -18,11 +18,7 @@ export const Navbar: FC = () => {
   const canViewDeployment = Boolean(permissions.viewDeploymentValues);
   const canViewAllUsers = Boolean(permissions.readAllUsers);
   const proxyContextValue = useProxy();
-  const dashboard = useDashboard();
-  const canViewHealth =
-    canViewDeployment &&
-    dashboard.experiments.includes("deployment_health_page");
-
+  const canViewHealth = canViewDeployment;
   return (
     <NavbarView
       user={me}
diff --git a/site/src/components/DeploySettingsLayout/Sidebar.tsx b/site/src/components/DeploySettingsLayout/Sidebar.tsx
@@ -52,11 +52,9 @@ export const Sidebar: FC = () => {
       <SidebarNavItem href="observability" icon={InsertChartIcon}>
         Observability
       </SidebarNavItem>
-      {dashboard.experiments.includes("deployment_health_page") && (
-        <SidebarNavItem href="/health" icon={MonitorHeartOutlined}>
-          Health
-        </SidebarNavItem>
-      )}
+      <SidebarNavItem href="/health" icon={MonitorHeartOutlined}>
+        Health
+      </SidebarNavItem>
     </BaseSidebar>
   );
 };
diff --git a/site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralSettingsPageView.stories.tsx b/site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralSettingsPageView.stories.tsx
@@ -40,7 +40,7 @@ const meta: Meta<typeof GeneralSettingsPageView> = {
       },
     ],
     deploymentDAUs: MockDeploymentDAUResponse,
-    safeExperiments: ["deployment_health_page"],
+    safeExperiments: [],
   },
 };
 
@@ -102,6 +102,6 @@ export const allExperimentsEnabled: Story = {
         hidden: false,
       },
     ],
-    safeExperiments: ["deployment_health_page"],
+    safeExperiments: [],
   },
 };
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -2047,9 +2047,7 @@ export const MockEntitlementsWithUserLimit: TypesGen.Entitlements = {
   }),
 };
 
-export const MockExperiments: TypesGen.Experiment[] = [
-  "deployment_health_page",
-];
+export const MockExperiments: TypesGen.Experiment[] = [];
 
 export const MockAuditLog: TypesGen.AuditLog = {
   id: "fbd2116a-8961-4954-87ae-e4575bd29ce0",
