Skip to content

Commit 1e1fd68

Browse files
committed
fix: omit users for allUsersGroup response
1 parent 69fce04 commit 1e1fd68

File tree

5 files changed

+9
-73
lines changed

5 files changed

+9
-73
lines changed

coderd/database/querier.go

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderd/database/queries.sql.go

-49
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderd/database/queries/groups.sql

-12
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,6 @@ AND
3636
AND
3737
users.deleted = 'false';
3838

39-
-- name: GetAllOrganizationMembers :many
40-
SELECT
41-
users.*
42-
FROM
43-
users
44-
JOIN
45-
organization_members
46-
ON
47-
users.id = organization_members.user_id
48-
WHERE
49-
organization_members.organization_id = $1;
50-
5139
-- name: GetGroupsByOrganizationID :many
5240
SELECT
5341
*

enterprise/coderd/templates.go

+5-8
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,13 @@ func (api *API) templateACL(rw http.ResponseWriter, r *http.Request) {
7878
for _, group := range dbGroups {
7979
var members []database.User
8080

81-
if group.Name == database.AllUsersGroup {
82-
members, err = api.Database.GetAllOrganizationMembers(ctx, group.OrganizationID)
83-
} else {
81+
if group.Name != database.AllUsersGroup {
8482
members, err = api.Database.GetGroupMembers(ctx, group.ID)
83+
if err != nil {
84+
httpapi.InternalServerError(rw, err)
85+
return
86+
}
8587
}
86-
if err != nil {
87-
httpapi.InternalServerError(rw, err)
88-
return
89-
}
90-
9188
groups = append(groups, codersdk.TemplateGroup{
9289
Group: convertGroup(group.Group, members),
9390
Role: convertToTemplateRole(group.Actions),

enterprise/coderd/templates_test.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ func TestTemplateACL(t *testing.T) {
7676
},
7777
})
7878

79-
_, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID)
79+
// Create a user to assert they aren't returned in the response.
80+
_, _ = coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID)
8081
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
8182
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
8283

@@ -87,8 +88,8 @@ func TestTemplateACL(t *testing.T) {
8788
require.NoError(t, err)
8889

8990
require.Len(t, acl.Groups, 1)
90-
require.Len(t, acl.Groups[0].Members, 2)
91-
require.Contains(t, acl.Groups[0].Members, user1)
91+
// We don't return members for the allUsers group.
92+
require.Len(t, acl.Groups[0].Members, 0)
9293
require.Len(t, acl.Users, 0)
9394
})
9495

0 commit comments

Comments
 (0)