fix: don't show promote button for members (cherry-pick #17511) (#17513)

gcp-cherry-pick-bot[bot] · web-flow · commit 1e8ac6c264cd · 2025-04-24T15:23:20.000+05:00
Co-authored-by: Bruno Quaresma <bruno@coder.com> Co-authored-by: M Atif Ali <atif@coder.com> fix: don't show promote button for members (#17511) Fix #15850
diff --git a/site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx b/site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx
@@ -33,7 +33,6 @@ export const VersionRow: FC<VersionRowProps> = ({
 	});
 
 	const jobStatus = version.job.status;
-	const showActions = onPromoteClick || onArchiveClick;
 
 	return (
 		<TimelineEntry
@@ -106,7 +105,7 @@ export const VersionRow: FC<VersionRowProps> = ({
 							</Pill>
 						)}
 
-						{showActions && jobStatus === "failed" ? (
+						{jobStatus === "failed" && onArchiveClick && (
 							<Button
 								css={styles.promoteButton}
 								disabled={isActive || version.archived}
@@ -118,7 +117,9 @@ export const VersionRow: FC<VersionRowProps> = ({
 							>
 								Archive&hellip;
 							</Button>
-						) : (
+						)}
+
+						{jobStatus === "succeeded" && onPromoteClick && (
 							<Button
 								css={styles.promoteButton}
 								disabled={isActive || jobStatus !== "succeeded"}
