chore: add sqlc-vet to github actions for validating queries

Emyrk · Emyrk · commit 1ea18a638bda · 2023-12-12T15:19:02.000-06:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -908,3 +908,27 @@ jobs:
 
             echo "::endgroup::"
           done
+
+  # sqlc-vet runs a postgres docker container, runs Coder migrations, and then
+  # runs sqlc-vet to ensure all queries are valid. This catches any mistakes
+  # in migrations or sqlc queries that makes a query unable to be prepared.
+  sqlc-vet:
+    runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
+    needs: changes
+    # TODO: We should do this on any migration or query changes.
+#    if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+      # We need golang to run the migration main.go
+      - name: Setup Go
+        uses: ./.github/actions/setup-go
+
+      - name: Setup sqlc
+        uses: ./.github/actions/setup-sqlc
+
+      - name: Setup and run sqlc vet
+        run: |
+          make sqlc-vet
diff --git a/Makefile b/Makefile
@@ -708,6 +708,11 @@ test:
 	gotestsum --format standard-quiet -- -v -short -count=1 ./...
 .PHONY: test
 
+sqlc-vet: test-postgres-docker
+	echo "--- sqlc vet"
+	SQLC_DATABASE_URL="postgresql://postgres:postgres@localhost:5432/$(shell go run scripts/migrate-ci/main.go)" \
+	sqlc vet -f coderd/database/sqlc.yaml
+
 # When updating -timeout for this test, keep in sync with
 # test-go-postgres (.github/workflows/coder.yaml).
 # Do add coverage flags so that test caching works.
diff --git a/coderd/database/sqlc.yaml b/coderd/database/sqlc.yaml
@@ -82,6 +82,12 @@ sql:
   - schema: "./dump.sql"
     queries: "./queries"
     engine: "postgresql"
+    # This only works if you are running a local postgres database with the
+    # schema loaded and migrations run.
+    database:
+      uri: "${SQLC_DATABASE_URL}"
+    rules:
+      - sqlc/db-prepare
     gen:
       go:
         package: "database"
