Fix pagination tests

presleyp · presleyp · commit 1ebab326a038 · 2022-10-25T18:32:59.000Z
diff --git a/site/src/components/PaginationWidget/PageButton.tsx b/site/src/components/PaginationWidget/PageButton.tsx
@@ -29,7 +29,7 @@ export const PageButton = ({
       aria-label={`${page === activePage ? "Current Page" : ""} ${
         page === numPages ? "Last Page" : ""
       } Page${page}`}
-      name="Page button"
+      name={page === undefined ? undefined : "Page button"}
       onClick={() => onPageClick && page && onPageClick(page)}
       disabled={disabled}
     >
diff --git a/site/src/components/PaginationWidget/PaginationWidget.test.tsx b/site/src/components/PaginationWidget/PaginationWidget.test.tsx
@@ -1,15 +1,15 @@
 import { screen } from "@testing-library/react"
 import { render } from "../../testHelpers/renderHelpers"
 import { PaginationWidget } from "./PaginationWidget"
+import { createPaginationRef } from "./utils"
 
 describe("PaginatedList", () => {
   it("displays an accessible previous and next button regardless of the number of pages", async () => {
     const { container } = render(
       <PaginationWidget
         prevLabel="Previous"
         nextLabel="Next"
-        onPrevClick={() => jest.fn()}
-        onNextClick={() => jest.fn()}
+        paginationRef={createPaginationRef({ page: 1, limit: 25 })}
       />,
     )
 
@@ -30,12 +30,8 @@ describe("PaginatedList", () => {
       <PaginationWidget
         prevLabel="Previous"
         nextLabel="Next"
-        onPrevClick={() => jest.fn()}
-        onNextClick={() => jest.fn()}
-        onPageClick={(_) => jest.fn()}
         numRecords={200}
-        numRecordsPerPage={12}
-        activePage={1}
+        paginationRef={createPaginationRef({ page: 1, limit: 12 })}
       />,
     )
 
@@ -50,12 +46,8 @@ describe("PaginatedList", () => {
       <PaginationWidget
         prevLabel="Previous"
         nextLabel="Next"
-        onPrevClick={() => jest.fn()}
-        onNextClick={() => jest.fn()}
-        onPageClick={(_) => jest.fn()}
         numRecords={200}
-        numRecordsPerPage={12}
-        activePage={6}
+        paginationRef={createPaginationRef({ page: 6, limit: 12 })}
       />,
     )
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export const PageButton = ({`
`29`	`29`	aria-label={`${page === activePage ? "Current Page" : ""} ${
`30`	`30`	`page === numPages ? "Last Page" : ""`
`31`	`31`	} Page${page}`}
`32`		`- name="Page button"`
	`32`	`+ name={page === undefined ? undefined : "Page button"}`
`33`	`33`	`onClick={() => onPageClick && page && onPageClick(page)}`
`34`	`34`	`disabled={disabled}`
`35`	`35`	`>`