revert calls

aslilac · aslilac · commit 20263c6a7014 · 2025-05-13T21:49:34.000Z
diff --git a/coderd/files/overlay_test.go b/coderd/files/overlay_test.go
@@ -21,11 +21,10 @@ func TestOverlayFS(t *testing.T) {
 	afero.WriteFile(b, ".terraform/modules/modules.json", []byte("{}"), 0o644)
 	afero.WriteFile(b, ".terraform/modules/example_module/main.tf", []byte("terraform {}"), 0o644)
 
-	it, err := files.NewOverlayFS(afero.NewIOFS(a), []files.Overlay{{
+	it := files.NewOverlayFS(afero.NewIOFS(a), []files.Overlay{{
 		Path: ".terraform/modules",
 		FS:   afero.NewIOFS(b),
 	}})
-	require.NoError(t, err)
 
 	content, err := fs.ReadFile(it, "main.tf")
 	require.NoError(t, err)
diff --git a/coderd/parameters.go b/coderd/parameters.go
@@ -97,14 +97,7 @@ func (api *API) templateVersionDynamicParameters(rw http.ResponseWriter, r *http
 				return
 			}
 			defer api.FileCache.Release(tf.CachedModuleFiles.UUID)
-			templateFS, err = files.NewOverlayFS(templateFS, []files.Overlay{{Path: ".terraform/modules", FS: moduleFilesFS}})
-			if err != nil {
-				httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
-					Message: "Internal error creating overlay filesystem.",
-					Detail:  err.Error(),
-				})
-				return
-			}
+			templateFS = files.NewOverlayFS(templateFS, []files.Overlay{{Path: ".terraform/modules", FS: moduleFilesFS}})
 		}
 	} else if !xerrors.Is(err, sql.ErrNoRows) {
 		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
