fix(site): Use correct UUID for web terminal when first opened

mafredri · mafredri · commit 21837254a093 · 2022-12-13T18:30:40.000Z
While working on #5403 I noticed the web terminal connects with a different UUID than what is serialized in the URL, this resulted in a new session being opened if I refreshed the page. The reasons seems to be that we were accessing raw DOM elements (`location.search`) for navigation and omitting `react-router-dom`. This resulted in a new navigation and UUID being generated after the fact.
diff --git a/site/src/pages/TerminalPage/TerminalPage.tsx b/site/src/pages/TerminalPage/TerminalPage.tsx
@@ -127,17 +127,19 @@ const TerminalPage: FC<
   // the reconnection token and workspace name found
   // from the router.
   useEffect(() => {
-    const search = new URLSearchParams(location.search)
-    search.set("reconnect", reconnectionToken)
+    if (searchParams.get("reconnect") === reconnectionToken) {
+      return
+    }
+    searchParams.set("reconnect", reconnectionToken)
     navigate(
       {
-        search: search.toString(),
+        search: searchParams.toString(),
       },
       {
         replace: true,
       },
     )
-  }, [location.search, navigate, reconnectionToken])
+  }, [searchParams, navigate, reconnectionToken])
 
   // Apply terminal options based on connection state.
   useEffect(() => {
