Complete self review

ammario · ammario · commit 21fa66badc2c · 2022-09-24T19:23:35.000Z
diff --git a/coderd/database/migrations/000053_last_seen_at.down.sql b/coderd/database/migrations/000053_last_seen_at.down.sql
@@ -1,3 +1,2 @@
 ALTER TABLE ONLY users
 	DROP COLUMN last_seen_at;
-
diff --git a/coderd/httpmw/apikey.go b/coderd/httpmw/apikey.go
@@ -318,6 +318,9 @@ func ExtractAPIKey(cfg ExtractAPIKeyConfig) func(http.Handler) http.Handler {
 					}
 				}
 
+				// We only want to update this occasionally to reduce DB write
+				// load. We update alongside the UserLink and APIKey since it's
+				// easier on the DB to colocate writes.
 				_, err = cfg.DB.UpdateUserLastSeenAt(ctx, database.UpdateUserLastSeenAtParams{
 					ID:         key.UserID,
 					LastSeenAt: database.Now(),

Original file line number	Diff line number	Diff line change
`@@ -318,6 +318,9 @@ func ExtractAPIKey(cfg ExtractAPIKeyConfig) func(http.Handler) http.Handler {`
`318`	`318`	`}`
`319`	`319`	`}`
`320`	`320`
	`321`	`+ // We only want to update this occasionally to reduce DB write`
	`322`	`+ // load. We update alongside the UserLink and APIKey since it's`
	`323`	`+ // easier on the DB to colocate writes.`
`321`	`324`	`_, err = cfg.DB.UpdateUserLastSeenAt(ctx, database.UpdateUserLastSeenAtParams{`
`322`	`325`	`ID: key.UserID,`
`323`	`326`	`LastSeenAt: database.Now(),`