fix(coderd/agentapi): always write agent stats when provided

mafredri · mafredri · commit 22d4860dad0c · 2024-03-21T12:12:26.000Z
Previously we were discarding agent stats due to the length of
connections by proto being zero.
diff --git a/coderd/agentapi/stats.go b/coderd/agentapi/stats.go
@@ -47,11 +47,11 @@ func (a *StatsAPI) now() time.Time {
 }
 
 func (a *StatsAPI) UpdateStats(ctx context.Context, req *agentproto.UpdateStatsRequest) (*agentproto.UpdateStatsResponse, error) {
-	// An empty stat means it's just looking for the report interval.
 	res := &agentproto.UpdateStatsResponse{
 		ReportInterval: durationpb.New(a.AgentStatsRefreshInterval),
 	}
-	if req.Stats == nil || len(req.Stats.ConnectionsByProto) == 0 {
+	// An empty stat means it's just looking for the report interval.
+	if req.Stats == nil {
 		return res, nil
 	}
 
diff --git a/coderd/agentapi/stats_test.go b/coderd/agentapi/stats_test.go
@@ -262,16 +262,14 @@ func TestUpdateStates(t *testing.T) {
 		require.NoError(t, err)
 	})
 
-	t.Run("NoConnectionsByProto", func(t *testing.T) {
+	t.Run("NoStats", func(t *testing.T) {
 		t.Parallel()
 
 		var (
 			dbM = dbmock.NewMockStore(gomock.NewController(t))
 			ps  = pubsub.NewInMemory()
 			req = &agentproto.UpdateStatsRequest{
-				Stats: &agentproto.Stats{
-					ConnectionsByProto: map[string]int64{}, // len() == 0
-				},
+				Stats: nil,
 			}
 		)
 		api := agentapi.StatsAPI{

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,11 @@ func (a *StatsAPI) now() time.Time {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func (a StatsAPI) UpdateStats(ctx context.Context, req agentproto.UpdateStatsRequest) (*agentproto.UpdateStatsResponse, error) {`
`50`		`- // An empty stat means it's just looking for the report interval.`
`51`	`50`	`res := &agentproto.UpdateStatsResponse{`
`52`	`51`	`ReportInterval: durationpb.New(a.AgentStatsRefreshInterval),`
`53`	`52`	`}`
`54`		`- if req.Stats == nil \|\| len(req.Stats.ConnectionsByProto) == 0 {`
	`53`	`+ // An empty stat means it's just looking for the report interval.`
	`54`	`+ if req.Stats == nil {`
`55`	`55`	`return res, nil`
`56`	`56`	`}`
`57`	`57`