fix

f0ssel · f0ssel · commit 233a6de11e08 · 2024-05-29T14:41:42.000Z
diff --git a/coderd/workspaceapps/proxy.go b/coderd/workspaceapps/proxy.go
@@ -573,7 +573,7 @@ func (s *Server) proxyWorkspaceApp(rw http.ResponseWriter, r *http.Request, appT
 	}
 
 	// This strips the session token from a workspace app request.
-	cookieHeaders := r.Header.Values("Cookie")
+	cookieHeaders := r.Header.Values("Cookie")[:]
 	r.Header.Del("Cookie")
 	for _, cookieHeader := range cookieHeaders {
 		r.Header.Add("Cookie", httpapi.StripCoderCookies(cookieHeader))
diff --git a/coderd/workspacestats/activitybump.go b/coderd/workspacestats/activitybump.go
@@ -41,7 +41,6 @@ func ActivityBumpWorkspace(ctx context.Context, log slog.Logger, db database.Sto
 	// low priority operations fail first.
 	ctx, cancel := context.WithTimeout(ctx, time.Second*15)
 	defer cancel()
-	// nolint:gocritic // (#13146) Will be moved soon as part of refactor.
 	err := db.ActivityBumpWorkspace(ctx, database.ActivityBumpWorkspaceParams{
 		NextAutostart: nextAutostart.UTC(),
 		WorkspaceID:   workspaceID,

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ func (s Server) proxyWorkspaceApp(rw http.ResponseWriter, r http.Request, appT`
`573`	`573`	`}`
`574`	`574`
`575`	`575`	`// This strips the session token from a workspace app request.`
`576`		`- cookieHeaders := r.Header.Values("Cookie")`
	`576`	`+ cookieHeaders := r.Header.Values("Cookie")[:]`
`577`	`577`	`r.Header.Del("Cookie")`
`578`	`578`	`for _, cookieHeader := range cookieHeaders {`
`579`	`579`	`r.Header.Add("Cookie", httpapi.StripCoderCookies(cookieHeader))`