fix: derive running ws stop time from deadline

greyscaled · greyscaled · commit 24ccaeefea14 · 2022-05-31T15:08:50.000Z
Summary:

When a workspace is on, the remaining time until shutdown needs to be
derived from the deadline timestamp, not implied from the TTL
diff --git a/site/src/components/WorkspaceSchedule/WorkspaceSchedule.tsx b/site/src/components/WorkspaceSchedule/WorkspaceSchedule.tsx
@@ -11,12 +11,13 @@ import { Link as RouterLink } from "react-router-dom"
 import { Workspace } from "../../api/typesGenerated"
 import { MONOSPACE_FONT_FAMILY } from "../../theme/constants"
 import { extractTimezone, stripTimezone } from "../../util/schedule"
+import { isWorkspaceOn } from "../../util/workspace"
 import { Stack } from "../Stack/Stack"
 
 dayjs.extend(duration)
 dayjs.extend(relativeTime)
 
-const Language = {
+export const Language = {
   autoStartDisplay: (schedule: string): string => {
     if (schedule) {
       return cronstrue.toString(stripTimezone(schedule), { throwExceptionOnParseError: false })
@@ -33,24 +34,31 @@ const Language = {
     }
   },
   autoStopDisplay: (workspace: Workspace): string => {
-    const latest = workspace.latest_build
+    const deadline = workspace.latest_build.deadline
+    const ttl = workspace.ttl
 
-    if (!workspace.ttl || workspace.ttl < 1) {
-      return "Manual"
-    }
-
-    if (latest.transition === "start") {
+    if (isWorkspaceOn(workspace)) {
+      // Workspace is on --> derive from latest_build.deadline. Note that the
+      // user may modify their workspace object (ttl) while the workspace is
+      // running and depending on system semantics, the deadline may still
+      // represent the previously defined ttl. Thus, we always derive from the
+      // deadline as the source of truth.
       const now = dayjs()
-      const updatedAt = dayjs(latest.updated_at)
-      const deadline = updatedAt.add(workspace.ttl / 1_000_000, "ms")
       if (now.isAfter(deadline)) {
         return "Workspace is shutting down now"
+      } else {
+        return now.to(deadline)
       }
-      return now.to(deadline)
+    } else if (!ttl || ttl < 1) {
+      // If the workspace is not on, and the ttl is 0 or undefined, then the
+      // workspace is set to manually shutdown.
+      return "Manual"
+    } else {
+      // The workspace has a ttl set, but is either in an unknown state or is
+      // not running. Therefore, we derive from workspace.ttl.
+      const duration = dayjs.duration(ttl / 1_000_000, "milliseconds")
+      return `${duration.humanize()} after start`
     }
-
-    const duration = dayjs.duration(workspace.ttl / 1_000_000, "milliseconds")
-    return `${duration.humanize()} after start`
   },
   editScheduleLink: "Edit schedule",
   schedule: "Schedule",
