fix(agent/agentcontainers): fix TestAPI/NoUpdaterLoopLogspam flake

DanielleMaywood · DanielleMaywood · commit 271e4c220b39 · 2025-07-16T19:20:18.000Z
diff --git a/agent/agentcontainers/api_test.go b/agent/agentcontainers/api_test.go
@@ -358,15 +358,22 @@ func TestAPI(t *testing.T) {
 			fakeCLI    = &fakeContainerCLI{
 				listErr: firstErr,
 			}
+			fWatcher = newFakeWatcher(t)
 		)
 
 		api := agentcontainers.NewAPI(logger,
+			agentcontainers.WithWatcher(fWatcher),
 			agentcontainers.WithClock(mClock),
 			agentcontainers.WithContainerCLI(fakeCLI),
 		)
 		api.Start()
 		defer api.Close()
 
+		// Wait for the watcher to have initialized. As the
+		// watcher logs, it can interfere with the test and
+		// cause a flake.
+		testutil.RequireReceive(ctx, t, fWatcher.nextCalled)
+
 		// Make sure the ticker function has been registered
 		// before advancing the clock.
 		tickerTrap.MustWait(ctx).MustRelease(ctx)
