refactor(enterprise/cli): remove provisionerd from slim binary (#9488)

mafredri · web-flow · commit 27ab0d9a84db · 2023-09-01T18:26:44.000Z
This change saves 8 MB in the slim binary. Ref: #9380
diff --git a/enterprise/cli/provisionerdaemons.go b/enterprise/cli/provisionerdaemons.go
@@ -1,3 +1,5 @@
+//go:build !slim
+
 package cli
 
 import (
diff --git a/enterprise/cli/provisionerdaemons_slim.go b/enterprise/cli/provisionerdaemons_slim.go
@@ -0,0 +1,23 @@
+//go:build slim
+
+package cli
+
+import (
+	"github.com/coder/coder/v2/cli/clibase"
+)
+
+func (r *RootCmd) provisionerDaemons() *clibase.Cmd {
+	cmd := &clibase.Cmd{
+		Use:   "provisionerd",
+		Short: "Manage provisioner daemons",
+		// We accept RawArgs so all commands and flags are accepted.
+		RawArgs: true,
+		Hidden:  true,
+		Handler: func(inv *clibase.Invocation) error {
+			slimUnsupported(inv.Stderr, "coder provisionerd")
+			return nil
+		},
+	}
+
+	return cmd
+}
diff --git a/enterprise/cli/proxyserver_slim.go b/enterprise/cli/proxyserver_slim.go
@@ -3,12 +3,7 @@
 package cli
 
 import (
-	"fmt"
-	"io"
-	"os"
-
 	"github.com/coder/coder/v2/cli/clibase"
-	"github.com/coder/coder/v2/cli/cliui"
 )
 
 func (r *RootCmd) proxyServer() *clibase.Cmd {
@@ -20,18 +15,10 @@ func (r *RootCmd) proxyServer() *clibase.Cmd {
 		RawArgs: true,
 		Hidden:  true,
 		Handler: func(inv *clibase.Invocation) error {
-			serverUnsupported(inv.Stderr)
+			slimUnsupported(inv.Stderr, "workspace-proxy server")
 			return nil
 		},
 	}
 
 	return root
 }
-
-func serverUnsupported(w io.Writer) {
-	_, _ = fmt.Fprintf(w, "You are using a 'slim' build of Coder, which does not support the %s subcommand.\n", cliui.DefaultStyles.Code.Render("server"))
-	_, _ = fmt.Fprintln(w, "")
-	_, _ = fmt.Fprintln(w, "Please use a build of Coder from GitHub releases:")
-	_, _ = fmt.Fprintln(w, "  https://github.com/coder/coder/releases")
-	os.Exit(1)
-}
diff --git a/enterprise/cli/root.go b/enterprise/cli/root.go
@@ -1,8 +1,13 @@
 package cli
 
 import (
+	"fmt"
+	"io"
+	"os"
+
 	"github.com/coder/coder/v2/cli"
 	"github.com/coder/coder/v2/cli/clibase"
+	"github.com/coder/coder/v2/cli/cliui"
 )
 
 type RootCmd struct {
@@ -24,3 +29,14 @@ func (r *RootCmd) EnterpriseSubcommands() []*clibase.Cmd {
 	all := append(r.Core(), r.enterpriseOnly()...)
 	return all
 }
+
+//nolint:unused
+func slimUnsupported(w io.Writer, cmd string) {
+	_, _ = fmt.Fprintf(w, "You are using a 'slim' build of Coder, which does not support the %s subcommand.\n", cliui.DefaultStyles.Code.Render(cmd))
+	_, _ = fmt.Fprintln(w, "")
+	_, _ = fmt.Fprintln(w, "Please use a build of Coder from GitHub releases:")
+	_, _ = fmt.Fprintln(w, "  https://github.com/coder/coder/releases")
+
+	//nolint:revive
+	os.Exit(1)
+}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+//go:build !slim`
	`2`	`+`
`1`	`3`	`package cli`
`2`	`4`
`3`	`5`	`import (`