Audit log proxy registers

Emyrk · Emyrk · commit 28deaca0f35e · 2023-05-05T09:54:04.000-05:00
diff --git a/coderd/database/queries/proxies.sql b/coderd/database/queries/proxies.sql
@@ -51,7 +51,7 @@ SET
 		WHEN length(@token_hashed_secret :: bytea) > 0  THEN @token_hashed_secret :: bytea
 		ELSE  workspace_proxies.token_hashed_secret
 	END,
-    -- Always update this timestamp.
+	-- Always update this timestamp.
 	updated_at = Now()
 WHERE
 	id = @id
@@ -85,7 +85,7 @@ SELECT
 FROM
 	workspace_proxies
 WHERE
-		deleted = false;
+	deleted = false;
 
 -- Finds a workspace proxy that has an access URL or app hostname that matches
 -- the provided hostname. This is to check if a hostname matches any workspace
diff --git a/enterprise/cli/workspaceproxy.go b/enterprise/cli/workspaceproxy.go
@@ -96,7 +96,7 @@ func (r *RootCmd) patchProxy() *clibase.Cmd {
 		},
 		clibase.Option{
 			Flag:        "display-name",
-			Description: "(Optional) Display of the proxy. If omitted, the name is reused as the display name.",
+			Description: "(Optional) Display of the proxy. A more human friendly name to be displayed.",
 			Value:       clibase.StringOf(&displayName),
 		},
 		clibase.Option{
diff --git a/enterprise/coderd/workspaceproxy.go b/enterprise/coderd/workspaceproxy.go
@@ -410,9 +410,18 @@ func (api *API) workspaceProxyIssueSignedAppToken(rw http.ResponseWriter, r *htt
 // @x-apidocgen {"skip": true}
 func (api *API) workspaceProxyRegister(rw http.ResponseWriter, r *http.Request) {
 	var (
-		ctx   = r.Context()
-		proxy = httpmw.WorkspaceProxy(r)
+		ctx               = r.Context()
+		proxy             = httpmw.WorkspaceProxy(r)
+		auditor           = api.AGPL.Auditor.Load()
+		aReq, commitAudit = audit.InitRequest[database.WorkspaceProxy](rw, &audit.RequestParams{
+			Audit:   *auditor,
+			Log:     api.Logger,
+			Request: r,
+			Action:  database.AuditActionWrite,
+		})
 	)
+	aReq.Old = proxy
+	defer commitAudit()
 
 	var req wsproxysdk.RegisterWorkspaceProxyRequest
 	if !httpapi.Read(ctx, rw, r, &req) {
@@ -437,7 +446,7 @@ func (api *API) workspaceProxyRegister(rw http.ResponseWriter, r *http.Request)
 		}
 	}
 
-	_, err := api.Database.RegisterWorkspaceProxy(ctx, database.RegisterWorkspaceProxyParams{
+	updatedProxy, err := api.Database.RegisterWorkspaceProxy(ctx, database.RegisterWorkspaceProxyParams{
 		ID:               proxy.ID,
 		Url:              req.AccessURL,
 		WildcardHostname: req.WildcardHostname,
@@ -451,6 +460,7 @@ func (api *API) workspaceProxyRegister(rw http.ResponseWriter, r *http.Request)
 		return
 	}
 
+	aReq.New = updatedProxy
 	httpapi.Write(ctx, rw, http.StatusCreated, wsproxysdk.RegisterWorkspaceProxyResponse{
 		AppSecurityKey: api.AppSecurityKey.String(),
 	})
