enable GitHub OAuth

matifali · web-flow · commit 29162dd2ac9b · 2023-07-26T12:48:02.000+03:00
diff --git a/.github/workflows/pr-deploy.yaml b/.github/workflows/pr-deploy.yaml
@@ -191,18 +191,17 @@ jobs:
           --set coder.env[1].value="*--pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}" \
           --set coder.env[2].name=CODER_EXPERIMENTS \
           --set coder.env[2].value="*" \
+          --set coder.env[3].name=CODER_OAUTH2_GITHUB_ALLOW_SIGNUPS \
+          --set coder.env[3].value=true \
+          --set coder.env[4].name=CODER_OAUTH2_GITHUB_CLIENT_ID \
+          --set coder.env[4].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_ID }} \
+          --set coder.env[5].name=CODER_OAUTH2_GITHUB_CLIENT_SECRET \
+          --set coder.env[5].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_SECRET }} \
+          --set coder.env[6].name=CODER_OAUTH2_GITHUB_ALLOWED_ORGS \
+          --set coder.env[6].value=coder \
+          --set coder.env[7].name=CODER_OAUTH2_GITHUB_REDIRECT_URI \
+          --set coder.env[7].value="https://pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}/gitauth/github/callback \
           --force
-          # Uncomment this when https://github.com/coder/coder/issues/8714 is resolved
-          # --set coder.env[3].name=CODER_OAUTH2_GITHUB_ALLOW_SIGNUPS \
-          # --set coder.env[3].value=true \
-          # --set coder.env[4].name=CODER_OAUTH2_GITHUB_CLIENT_ID \
-          # --set coder.env[4].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_ID }} \
-          # --set coder.env[5].name=CODER_OAUTH2_GITHUB_CLIENT_SECRET \
-          # --set coder.env[5].value=${{ secrets.PR_DEPLOYMENTS_GITHUB_OAUTH_CLIENT_SECRET }} \
-          # --set coder.env[6].name=CODER_OAUTH2_GITHUB_ALLOWED_ORGS \
-          # --set coder.env[6].value=coder \
-          # --set coder.env[7].name=CODER_OAUTH2_GITHUB_REDIRECT_URI \
-          # --set coder.env[7].value="https://pr${{ env.PR_NUMBER }}.${{ secrets.PR_DEPLOYMENTS_DOMAIN }}/gitauth/github/callback
 
       - name: Install coder-logstream-kube
         run: |
