Skip to content

Commit 29eccbe

Browse files
authored
ci: revert skips of required checks (#3303)
These were putting certain PRs in an unmergeable state.
1 parent d12e6b3 commit 29eccbe

File tree

7 files changed

+1
-184
lines changed

7 files changed

+1
-184
lines changed

.github/workflows/coder.yaml

+1-44
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ jobs:
3434
runs-on: ubuntu-latest
3535
outputs:
3636
docs-only: ${{ steps.filter.outputs.docs_count == steps.filter.outputs.all_count }}
37-
go: ${{ steps.filter.outputs.go }}
3837
sh: ${{ steps.filter.outputs.sh }}
3938
steps:
4039
- uses: actions/checkout@v3
@@ -49,10 +48,6 @@ jobs:
4948
- 'docs/**'
5049
# For testing:
5150
# - '.github/**'
52-
go:
53-
- "**.go"
54-
- "**.mod"
55-
- "**.sum"
5651
sh:
5752
- "**.sh"
5853
- id: debug
@@ -63,36 +58,15 @@ jobs:
6358
debug-inputs:
6459
needs:
6560
- changes
66-
- pr-context
6761
runs-on: ubuntu-latest
6862
steps:
6963
- id: log
7064
run: |
7165
echo "${{ toJSON(needs) }}"
72-
echo "${{ contains(needs.pr-context.outputs.skips, 'test/go/postgres') }} "
73-
echo "${{ contains(needs.pr-context.outputs.skips, 'test/e2e') }} "
74-
75-
pr-context:
76-
runs-on: ubuntu-latest
77-
outputs:
78-
skips: ${{ steps.pr-context.outputs.skips }}
79-
steps:
80-
- uses: actions/checkout@v3
81-
- uses: actions/setup-go@v3
82-
with:
83-
go-version: "~1.18"
84-
- id: pr-context
85-
env:
86-
GITHUB_CONTEXT: ${{ toJSON(github) }}
87-
run: |
88-
(cd .github/workflows/prcontext && go build)
89-
./.github/workflows/prcontext/prcontext
9066
9167
style-lint-golangci:
9268
name: style/lint/golangci
9369
timeout-minutes: 5
94-
needs: changes
95-
if: needs.changes.outputs.go == 'true'
9670
runs-on: ubuntu-latest
9771
steps:
9872
- uses: actions/checkout@v3
@@ -108,8 +82,6 @@ jobs:
10882
name: style/lint/shellcheck
10983
timeout-minutes: 5
11084
runs-on: ubuntu-latest
111-
needs: changes
112-
if: needs.changes.outputs.sh == 'true'
11385
steps:
11486
- uses: actions/checkout@v3
11587
- name: Run ShellCheck
@@ -122,8 +94,6 @@ jobs:
12294
style-lint-typescript:
12395
name: "style/lint/typescript"
12496
timeout-minutes: 5
125-
needs: changes
126-
if: needs.changes.outputs.docs-only == 'false'
12797
runs-on: ubuntu-latest
12898
steps:
12999
- name: Checkout
@@ -207,8 +177,6 @@ jobs:
207177

208178
style-fmt:
209179
name: "style/fmt"
210-
needs: changes
211-
if: needs.changes.outputs.docs-only == 'false'
212180
runs-on: ubuntu-latest
213181
timeout-minutes: 5
214182
steps:
@@ -241,8 +209,6 @@ jobs:
241209
242210
test-go:
243211
name: "test/go"
244-
needs: changes
245-
if: needs.changes.outputs.docs-only == 'false'
246212
runs-on: ${{ matrix.os }}
247213
timeout-minutes: 20
248214
strategy:
@@ -328,12 +294,6 @@ jobs:
328294

329295
test-go-postgres:
330296
name: "test/go/postgres"
331-
needs:
332-
- changes
333-
- pr-context
334-
if: >
335-
needs.changes.outputs.docs-only == 'false' &&
336-
!contains(needs.pr-context.outputs.skips, 'test/go/postgres')
337297
runs-on: ubuntu-latest
338298
# This timeout must be greater than the timeout set by `go test` in
339299
# `make test-postgres` to ensure we receive a trace of running
@@ -514,8 +474,6 @@ jobs:
514474

515475
test-js:
516476
name: "test/js"
517-
needs: changes
518-
if: needs.changes.outputs.docs-only == 'false'
519477
runs-on: ubuntu-latest
520478
timeout-minutes: 20
521479
steps:
@@ -571,8 +529,7 @@ jobs:
571529
name: "test/e2e/${{ matrix.os }}"
572530
needs:
573531
- changes
574-
- pr-context
575-
if: needs.changes.outputs.docs-only == 'false' && !contains(needs.pr-context.outputs.skips, 'test/e2e')
532+
if: needs.changes.outputs.docs-only == 'false'
576533
runs-on: ${{ matrix.os }}
577534
timeout-minutes: 20
578535
strategy:

.github/workflows/prcontext/README.md

-7
This file was deleted.

.github/workflows/prcontext/go.mod

-12
This file was deleted.

.github/workflows/prcontext/go.sum

-16
This file was deleted.

.github/workflows/prcontext/main.go

-39
This file was deleted.

.github/workflows/prcontext/parse.go

-28
This file was deleted.

.github/workflows/prcontext/parse_test.go

-38
This file was deleted.

0 commit comments

Comments
 (0)