make linter happy

johnstcn · johnstcn · commit 2a0746de260d · 2023-03-09T10:59:23.000Z
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -795,6 +795,7 @@ func (api *API) CreateInMemoryProvisionerDaemon(ctx context.Context, debounce ti
 	}()
 
 	name := namesgenerator.GetRandomName(1)
+	// nolint:gocritic // Inserting a provisioner daemon is a system function.
 	daemon, err := api.Database.InsertProvisionerDaemon(dbauthz.AsSystemRestricted(ctx), database.InsertProvisionerDaemonParams{
 		ID:           uuid.New(),
 		CreatedAt:    database.Now(),
diff --git a/coderd/updatecheck/updatecheck.go b/coderd/updatecheck/updatecheck.go
@@ -225,6 +225,7 @@ func (c *Checker) notifyIfNewer(prev, next Result) {
 }
 
 func (c *Checker) lastUpdateCheck(ctx context.Context) (r Result, err error) {
+	// nolint:gocritic // Getting the last update check is a system function.
 	s, err := c.db.GetLastUpdateCheck(dbauthz.AsSystemRestricted(ctx))
 	if err != nil {
 		return r, err
diff --git a/coderd/users.go b/coderd/users.go
@@ -37,6 +37,7 @@ import (
 // @Router /users/first [get]
 func (api *API) firstUser(rw http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
+	// nolint:gocritic // Getting user count is a system function.
 	userCount, err := api.Database.GetUserCount(dbauthz.AsSystemRestricted(ctx))
 	if err != nil {
 		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
@@ -70,14 +71,14 @@ func (api *API) firstUser(rw http.ResponseWriter, r *http.Request) {
 // @Success 201 {object} codersdk.CreateFirstUserResponse
 // @Router /users/first [post]
 func (api *API) postFirstUser(rw http.ResponseWriter, r *http.Request) {
-	// TODO: Should this admin system context be in a middleware?
 	ctx := r.Context()
 	var createUser codersdk.CreateFirstUserRequest
 	if !httpapi.Read(ctx, rw, r, &createUser) {
 		return
 	}
 
 	// This should only function for the first user.
+	// nolint:gocritic // Getting user count is a system function.
 	userCount, err := api.Database.GetUserCount(dbauthz.AsSystemRestricted(ctx))
 	if err != nil {
 		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
diff --git a/enterprise/replicasync/replicasync.go b/enterprise/replicasync/replicasync.go
@@ -62,6 +62,7 @@ func New(ctx context.Context, logger slog.Logger, db database.Store, pubsub data
 	if err != nil {
 		return nil, xerrors.Errorf("ping database: %w", err)
 	}
+	// nolint:gocritic // Inserting a replica is a system function.
 	replica, err := db.InsertReplica(dbauthz.AsSystemRestricted(ctx), database.InsertReplicaParams{
 		ID:              options.ID,
 		CreatedAt:       database.Now(),
@@ -142,6 +143,7 @@ func (m *Manager) loop(ctx context.Context) {
 		case <-ctx.Done():
 			return
 		case <-deleteTicker.C:
+			// nolint:gocritic // Deleting a replica is a system function
 			err := m.db.DeleteReplicasUpdatedBefore(dbauthz.AsSystemRestricted(ctx), m.updateInterval())
 			if err != nil {
 				m.logger.Warn(ctx, "delete old replicas", slog.Error(err))
@@ -219,6 +221,7 @@ func (m *Manager) syncReplicas(ctx context.Context) error {
 	defer m.closeWait.Done()
 	// Expect replicas to update once every three times the interval...
 	// If they don't, assume death!
+	// nolint:gocritic // Reading replicas is a system function
 	replicas, err := m.db.GetReplicasUpdatedAfter(dbauthz.AsSystemRestricted(ctx), m.updateInterval())
 	if err != nil {
 		return xerrors.Errorf("get replicas: %w", err)
@@ -367,6 +370,7 @@ func (m *Manager) Close() error {
 	defer m.mutex.Unlock()
 	ctx, cancelFunc := context.WithTimeout(context.Background(), 5*time.Second)
 	defer cancelFunc()
+	// nolint:gocritic // Updating a replica is a sytsem function.
 	_, err := m.db.UpdateReplica(dbauthz.AsSystemRestricted(ctx), database.UpdateReplicaParams{
 		ID:        m.self.ID,
 		UpdatedAt: database.Now(),

Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,7 @@ func (c *Checker) notifyIfNewer(prev, next Result) {`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`func (c *Checker) lastUpdateCheck(ctx context.Context) (r Result, err error) {`
	`228`	`+ // nolint:gocritic // Getting the last update check is a system function.`
`228`	`229`	`s, err := c.db.GetLastUpdateCheck(dbauthz.AsSystemRestricted(ctx))`
`229`	`230`	`if err != nil {`
`230`	`231`	`return r, err`