Fix unused method receiver

kylecarbs · kylecarbs · commit 2c9fb644cc19 · 2023-02-26T22:15:11.000Z
diff --git a/cli/create_test.go b/cli/create_test.go
@@ -701,35 +701,28 @@ func createTestParseResponseWithDefault(defaultValue string) []*proto.Parse_Resp
 }
 
 type oauth2Config struct {
-	token *oauth2.Token
 }
 
 func (*oauth2Config) AuthCodeURL(state string, _ ...oauth2.AuthCodeOption) string {
 	return "/?state=" + url.QueryEscape(state)
 }
 
-func (o *oauth2Config) Exchange(context.Context, string, ...oauth2.AuthCodeOption) (*oauth2.Token, error) {
+func (*oauth2Config) Exchange(context.Context, string, ...oauth2.AuthCodeOption) (*oauth2.Token, error) {
 	return &oauth2.Token{
 		AccessToken:  "token",
 		RefreshToken: "refresh",
 		Expiry:       database.Now().Add(time.Hour),
 	}, nil
 }
 
-func (o *oauth2Config) TokenSource(context.Context, *oauth2.Token) oauth2.TokenSource {
-	return &oauth2TokenSource{
-		token: o.token,
-	}
+func (*oauth2Config) TokenSource(context.Context, *oauth2.Token) oauth2.TokenSource {
+	return &oauth2TokenSource{}
 }
 
 type oauth2TokenSource struct {
-	token *oauth2.Token
 }
 
-func (o *oauth2TokenSource) Token() (*oauth2.Token, error) {
-	if o.token != nil {
-		return o.token, nil
-	}
+func (*oauth2TokenSource) Token() (*oauth2.Token, error) {
 	return &oauth2.Token{
 		AccessToken:  "token",
 		RefreshToken: "refresh",
diff --git a/site/package.json b/site/package.json
@@ -136,6 +136,6 @@
     "chrome 66",
     "firefox 63",
     "edge 79",
-    "safari 15.4"
+    "safari 15.5"
   ]
 }
diff --git a/site/src/pages/GitAuthPage/GitAuthPage.tsx b/site/src/pages/GitAuthPage/GitAuthPage.tsx
@@ -3,25 +3,19 @@ import { makeStyles } from "@material-ui/core/styles"
 import { SignInLayout } from "components/SignInLayout/SignInLayout"
 import { Welcome } from "components/Welcome/Welcome"
 import { FC, useEffect } from "react"
-import { Link as RouterLink, useSearchParams } from "react-router-dom"
+import { Link as RouterLink } from "react-router-dom"
 import { REFRESH_GITAUTH_BROADCAST_CHANNEL } from "xServices/createWorkspace/createWorkspaceXService"
 
 const GitAuthPage: FC = () => {
   const styles = useStyles()
-  const [searchParams] = useSearchParams()
-  const shouldNotify = searchParams.has("notify")
   useEffect(() => {
-    if (!shouldNotify) {
-      return
-    }
-
     // This is used to notify the parent window that the Git auth token has been refreshed.
     // It's critical in the create workspace flow!
     const bc = new BroadcastChannel(REFRESH_GITAUTH_BROADCAST_CHANNEL)
     // The message doesn't matter, any message refreshes the page!
     bc.postMessage("noop")
     window.close()
-  }, [shouldNotify])
+  }, [])
 
   return (
     <SignInLayout>

Original file line number	Diff line number	Diff line change
`@@ -701,35 +701,28 @@ func createTestParseResponseWithDefault(defaultValue string) []*proto.Parse_Resp`
`701`	`701`	`}`
`702`	`702`
`703`	`703`	`type oauth2Config struct {`
`704`		`- token *oauth2.Token`
`705`	`704`	`}`
`706`	`705`
`707`	`706`	`func (*oauth2Config) AuthCodeURL(state string, _ ...oauth2.AuthCodeOption) string {`
`708`	`707`	`return "/?state=" + url.QueryEscape(state)`
`709`	`708`	`}`
`710`	`709`
`711`		`-func (o oauth2Config) Exchange(context.Context, string, ...oauth2.AuthCodeOption) (oauth2.Token, error) {`
	`710`	`+func (oauth2Config) Exchange(context.Context, string, ...oauth2.AuthCodeOption) (oauth2.Token, error) {`
`712`	`711`	`return &oauth2.Token{`
`713`	`712`	`AccessToken: "token",`
`714`	`713`	`RefreshToken: "refresh",`
`715`	`714`	`Expiry: database.Now().Add(time.Hour),`
`716`	`715`	`}, nil`
`717`	`716`	`}`
`718`	`717`
`719`		`-func (o oauth2Config) TokenSource(context.Context, oauth2.Token) oauth2.TokenSource {`
`720`		`- return &oauth2TokenSource{`
`721`		`- token: o.token,`
`722`		`- }`
	`718`	`+func (oauth2Config) TokenSource(context.Context, oauth2.Token) oauth2.TokenSource {`
	`719`	`+ return &oauth2TokenSource{}`
`723`	`720`	`}`
`724`	`721`
`725`	`722`	`type oauth2TokenSource struct {`
`726`		`- token *oauth2.Token`
`727`	`723`	`}`
`728`	`724`
`729`		`-func (o oauth2TokenSource) Token() (oauth2.Token, error) {`
`730`		`- if o.token != nil {`
`731`		`- return o.token, nil`
`732`		`- }`
	`725`	`+func (oauth2TokenSource) Token() (oauth2.Token, error) {`
`733`	`726`	`return &oauth2.Token{`
`734`	`727`	`AccessToken: "token",`
`735`	`728`	`RefreshToken: "refresh",`
Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,6 @@`
`136`	`136`	`"chrome 66",`
`137`	`137`	`"firefox 63",`
`138`	`138`	`"edge 79",`
`139`		`- "safari 15.4"`
	`139`	`+ "safari 15.5"`
`140`	`140`	`]`
`141`	`141`	`}`