fix: require client pipe to be closed in provisionerd test (#6188)

kylecarbs · web-flow · commit 2d0a69ba473a · 2023-02-14T00:46:05.000Z
https://github.com/coder/coder/actions/runs/4165019548/jobs/7207442687
diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go
@@ -1090,10 +1090,16 @@ func createProvisionerDaemonClient(t *testing.T, server provisionerDaemonTestSer
 	require.NoError(t, err)
 	srv := drpcserver.New(mux)
 	ctx, cancelFunc := context.WithCancel(context.Background())
-	t.Cleanup(cancelFunc)
+	closed := make(chan struct{})
 	go func() {
+		defer close(closed)
 		_ = srv.Serve(ctx, serverPipe)
 	}()
+	t.Cleanup(func() {
+		cancelFunc()
+		_ = serverPipe.Close()
+		<-closed
+	})
 	return proto.NewDRPCProvisionerDaemonClient(clientPipe)
 }
 
