Skip to content

Commit 2da0702

Browse files
fix(helm): missing templating for deployment labels (#6869)
Co-authored-by: Dean Sheather <dean@deansheather.com>
1 parent a32951c commit 2da0702

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

helm/templates/coder.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,16 @@ metadata:
77
annotations: {{ toYaml .Values.coder.serviceAccount.annotations | nindent 4 }}
88
labels:
99
{{- include "coder.labels" . | nindent 4 }}
10-
1110
---
1211
apiVersion: apps/v1
1312
kind: Deployment
1413
metadata:
1514
name: coder
1615
labels:
1716
{{- include "coder.labels" . | nindent 4 }}
17+
{{- with .Values.coder.labels }}
18+
{{- toYaml . | nindent 4 }}
19+
{{- end }}
1820
annotations: {{ toYaml .Values.coder.annotations | nindent 4}}
1921
spec:
2022
replicas: {{ .Values.coder.replicaCount }}

helm/values.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ coder:
3434
# https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
3535
annotations: {}
3636

37-
# coder.podAnnotations -- The Coder pod annotations. See:
38-
# https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
39-
podAnnotations: {}
40-
4137
# coder.labels -- The Deployment labels. See:
4238
# https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
4339
labels: {}
4440

41+
# coder.podAnnotations -- The Coder pod annotations. See:
42+
# https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
43+
podAnnotations: {}
44+
4545
# coder.serviceAccount -- Configuration for the automatically created service
4646
# account. Creation of the service account cannot be disabled.
4747
serviceAccount:

0 commit comments

Comments
 (0)