Add comment

kylecarbs · kylecarbs · commit 2dcf1f884d13 · 2022-09-16T14:52:23.000-05:00
diff --git a/enterprise/coderd/coderd.go b/enterprise/coderd/coderd.go
@@ -135,6 +135,7 @@ func (api *API) updateEntitlements(ctx context.Context) error {
 	}
 	auditLogs := codersdk.EntitlementNotEntitled
 
+	// Here we loop through licenses to detect enabled features.
 	for _, l := range licenses {
 		claims, err := validateDBLicense(l, api.Keys)
 		if err != nil {
diff --git a/enterprise/coderd/licenses_test.go b/enterprise/coderd/licenses_test.go
@@ -20,7 +20,7 @@ import (
 func TestPostLicense(t *testing.T) {
 	t.Parallel()
 
-	t.Run("POST", func(t *testing.T) {
+	t.Run("Success", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_ = coderdtest.CreateFirstUser(t, client)
@@ -37,7 +37,7 @@ func TestPostLicense(t *testing.T) {
 		assert.Equal(t, json.Number("1"), features[codersdk.FeatureAuditLog])
 	})
 
-	t.Run("POST_unauthorized", func(t *testing.T) {
+	t.Run("Unauthorized", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_, err := client.AddLicense(context.Background(), codersdk.AddLicenseRequest{
@@ -51,7 +51,7 @@ func TestPostLicense(t *testing.T) {
 		}
 	})
 
-	t.Run("POST_corrupted", func(t *testing.T) {
+	t.Run("Corrupted", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_ = coderdtest.CreateFirstUser(t, client)
@@ -70,7 +70,7 @@ func TestPostLicense(t *testing.T) {
 
 func TestGetLicense(t *testing.T) {
 	t.Parallel()
-	t.Run("GET", func(t *testing.T) {
+	t.Run("Success", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_ = coderdtest.CreateFirstUser(t, client)
@@ -108,7 +108,7 @@ func TestGetLicense(t *testing.T) {
 
 func TestDeleteLicense(t *testing.T) {
 	t.Parallel()
-	t.Run("DELETE_empty", func(t *testing.T) {
+	t.Run("Empty", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_ = coderdtest.CreateFirstUser(t, client)
@@ -124,7 +124,7 @@ func TestDeleteLicense(t *testing.T) {
 		}
 	})
 
-	t.Run("DELETE_bad_id", func(t *testing.T) {
+	t.Run("BadID", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_ = coderdtest.CreateFirstUser(t, client)
@@ -137,7 +137,7 @@ func TestDeleteLicense(t *testing.T) {
 		require.NoError(t, resp.Body.Close())
 	})
 
-	t.Run("DELETE", func(t *testing.T) {
+	t.Run("Success", func(t *testing.T) {
 		t.Parallel()
 		client := coderdenttest.New(t, nil)
 		_ = coderdtest.CreateFirstUser(t, client)

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ func (api *API) updateEntitlements(ctx context.Context) error {`
`135`	`135`	`}`
`136`	`136`	`auditLogs := codersdk.EntitlementNotEntitled`
`137`	`137`
	`138`	`+ // Here we loop through licenses to detect enabled features.`
`138`	`139`	`for _, l := range licenses {`
`139`	`140`	`claims, err := validateDBLicense(l, api.Keys)`
`140`	`141`	`if err != nil {`