rowback a few decisions

BrunoQuaresma · BrunoQuaresma · commit 2e542ca06cb1 · 2024-01-16T20:33:15.000Z
diff --git a/site/src/components/Resources/AgentRowPreview.tsx b/site/src/components/Resources/AgentRowPreview.tsx
@@ -107,6 +107,14 @@ export const AgentRowPreview: FC<AgentRowPreviewProps> = ({
                   {DisplayAppNameMap["web_terminal"]}
                 </AppPreview>
               )}
+              {agent.display_apps.includes("ssh_helper") && (
+                <AppPreview>{DisplayAppNameMap["ssh_helper"]}</AppPreview>
+              )}
+              {agent.display_apps.includes("port_forwarding_helper") && (
+                <AppPreview>
+                  {DisplayAppNameMap["port_forwarding_helper"]}
+                </AppPreview>
+              )}
               {/* VSCode display apps (vscode, vscode_insiders) get special presentation */}
               {agent.display_apps.includes("vscode") ? (
                 <AppPreview>
diff --git a/site/src/components/Resources/AppLink/AppLink.tsx b/site/src/components/Resources/AppLink/AppLink.tsx
@@ -14,8 +14,8 @@ import { BaseIcon } from "./BaseIcon";
 import { ShareIcon } from "./ShareIcon";
 
 export const DisplayAppNameMap: Record<TypesGen.DisplayApp, string> = {
-  port_forwarding_helper: "Open ports",
-  ssh_helper: "Connect SSH",
+  port_forwarding_helper: "Ports",
+  ssh_helper: "SSH",
   vscode: "VS Code Desktop",
   vscode_insiders: "VS Code Insiders",
   web_terminal: "Terminal",
diff --git a/site/src/components/Resources/PortForwardButton.tsx b/site/src/components/Resources/PortForwardButton.tsx
@@ -25,7 +25,6 @@ import {
   PopoverContent,
   PopoverTrigger,
 } from "components/Popover/Popover";
-import { DisplayAppNameMap } from "./AppLink/AppLink";
 import KeyboardArrowDown from "@mui/icons-material/KeyboardArrowDown";
 
 export interface PortForwardButtonProps {
@@ -75,7 +74,7 @@ export const PortForwardButton: FC<PortForwardButtonProps> = (props) => {
             )
           }
         >
-          {DisplayAppNameMap["port_forwarding_helper"]}
+          Open ports
         </Button>
       </PopoverTrigger>
       <PopoverContent horizontal="right" classes={{ paper }}>
diff --git a/site/src/components/Resources/SSHButton/SSHButton.tsx b/site/src/components/Resources/SSHButton/SSHButton.tsx
@@ -14,7 +14,6 @@ import {
   PopoverTrigger,
 } from "components/Popover/Popover";
 import { Stack } from "components/Stack/Stack";
-import { DisplayAppNameMap } from "../AppLink/AppLink";
 import Button from "@mui/material/Button";
 import KeyboardArrowDown from "@mui/icons-material/KeyboardArrowDown";
 
@@ -42,7 +41,7 @@ export const SSHButton: FC<PropsWithChildren<SSHButtonProps>> = ({
           endIcon={<KeyboardArrowDown />}
           css={{ fontSize: 13, padding: "8px 12px" }}
         >
-          {DisplayAppNameMap["ssh_helper"]}
+          Connect to SSH
         </Button>
       </PopoverTrigger>
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ import {`
`25`	`25`	`PopoverContent,`
`26`	`26`	`PopoverTrigger,`
`27`	`27`	`} from "components/Popover/Popover";`
`28`		`-import { DisplayAppNameMap } from "./AppLink/AppLink";`
`29`	`28`	`import KeyboardArrowDown from "@mui/icons-material/KeyboardArrowDown";`
`30`	`29`
`31`	`30`	`export interface PortForwardButtonProps {`
`@@ -75,7 +74,7 @@ export const PortForwardButton: FC<PortForwardButtonProps> = (props) => {`
`75`	`74`	`)`
`76`	`75`	`}`
`77`	`76`	`>`
`78`		`- {DisplayAppNameMap["port_forwarding_helper"]}`
	`77`	`+ Open ports`
`79`	`78`	`</Button>`
`80`	`79`	`</PopoverTrigger>`
`81`	`80`	`<PopoverContent horizontal="right" classes={{ paper }}>`