test(agent/agentcontainers): fix test data race due to list manipulation (#18250)

mafredri · web-flow · commit 2f8b056e271d · 2025-06-05T14:53:35.000Z
Fixes coder/internal#675
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -378,6 +378,8 @@ func (api *API) updateContainers(ctx context.Context) error {
 
 		return xerrors.Errorf("list containers failed: %w", err)
 	}
+	// Clone to avoid test flakes due to data manipulation.
+	updated.Containers = slices.Clone(updated.Containers)
 
 	api.mu.Lock()
 	defer api.mu.Unlock()

Original file line number	Diff line number	Diff line change
`@@ -378,6 +378,8 @@ func (api *API) updateContainers(ctx context.Context) error {`
`378`	`378`
`379`	`379`	`return xerrors.Errorf("list containers failed: %w", err)`
`380`	`380`	`}`
	`381`	`+ // Clone to avoid test flakes due to data manipulation.`
	`382`	`+ updated.Containers = slices.Clone(updated.Containers)`
`381`	`383`
`382`	`384`	`api.mu.Lock()`
`383`	`385`	`defer api.mu.Unlock()`