chore: improve variable name

brettkolodny · brettkolodny · commit 2fd588912360 · 2025-08-27T20:17:45.000Z
diff --git a/cli/sharing.go b/cli/sharing.go
@@ -131,9 +131,9 @@ func (r *RootCmd) shareWorkspace(orgContext *OrganizationContext) *serpent.Comma
 					role := groupAndRole[2]
 
 					var orgGroup *codersdk.Group
-					for _, g := range orgGroups {
-						if g.Name == groupName {
-							orgGroup = &g
+					for _, group := range orgGroups {
+						if group.Name == groupName {
+							orgGroup = &group
 							break
 						}
 					}
diff --git a/cli/sharing_test.go b/cli/sharing_test.go
@@ -116,16 +116,8 @@ func TestSharingShare(t *testing.T) {
 			Role: codersdk.WorkspaceRoleUse,
 		})
 
-		// Test that the users appear in the output
-		outputLines := strings.Split(out.String(), "\n")
-		userNames := []string{toShareWithUser1.Username, toShareWithUser2.Username}
-		for _, username := range userNames {
-			index := slices.IndexFunc(outputLines, func(line string) bool {
-				return strings.Contains(line, username)
-			})
-
-			assert.True(t, index != -1, fmt.Sprintf("Expected to find the username %s in the command output: %s", username, out.String()))
-		}
+		assert.Contains(t, out.String(), toShareWithUser1.Username)
+		assert.Contains(t, out.String(), toShareWithUser2.Username)
 	})
 
 	t.Run("ShareWithUsers_Roles", func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -131,9 +131,9 @@ func (r RootCmd) shareWorkspace(orgContext OrganizationContext) *serpent.Comma`
`131`	`131`	`role := groupAndRole[2]`
`132`	`132`
`133`	`133`	`var orgGroup *codersdk.Group`
`134`		`- for _, g := range orgGroups {`
`135`		`- if g.Name == groupName {`
`136`		`- orgGroup = &g`
	`134`	`+ for _, group := range orgGroups {`
	`135`	`+ if group.Name == groupName {`
	`136`	`+ orgGroup = &group`
`137`	`137`	`break`
`138`	`138`	`}`
`139`	`139`	`}`