fix assignOp linting errors

Claude · Claude · commit 31311d32c47e · 2025-03-26T06:14:02.000Z
diff --git a/cli/help.go b/cli/help.go
@@ -190,7 +190,7 @@ var usageTemplate = func() *template.Template {
 				},
 				"formatGroupDescription": func(s string) string {
 					s = strings.ReplaceAll(s, "\n", "")
-					s = s + "\n"
+					s += "\n"
 					s = wrapTTY(s)
 					return s
 				},
diff --git a/cli/root.go b/cli/root.go
@@ -1045,7 +1045,7 @@ func formatMultiError(from string, multi []error, opts *formatOpts) string {
 		prefix := fmt.Sprintf("%d. ", i+1)
 		if len(prefix) < len(indent) {
 			// Indent the prefix to match the indent
-			prefix = prefix + strings.Repeat(" ", len(indent)-len(prefix))
+			prefix += strings.Repeat(" ", len(indent)-len(prefix))
 		}
 		errStr = prefix + errStr
 		// Now looks like
diff --git a/cli/util.go b/cli/util.go
@@ -167,7 +167,7 @@ func parseCLISchedule(parts ...string) (*cron.Schedule, error) {
 func parseDuration(raw string) (time.Duration, error) {
 	// If the user input a raw number, assume minutes
 	if isDigit(raw) {
-		raw = raw + "m"
+		raw += "m"
 	}
 	d, err := time.ParseDuration(raw)
 	if err != nil {
diff --git a/coderd/prometheusmetrics/insights/metricscollector.go b/coderd/prometheusmetrics/insights/metricscollector.go
@@ -287,7 +287,7 @@ func convertParameterInsights(rows []database.GetTemplateParameterInsightsRow) [
 			if _, ok := m[key]; !ok {
 				m[key] = 0
 			}
-			m[key] = m[key] + r.Count
+			m[key] += r.Count
 		}
 	}
 
diff --git a/coderd/workspaceapps/appurl/appurl.go b/coderd/workspaceapps/appurl/appurl.go
@@ -267,7 +267,7 @@ func CompileHostnamePattern(pattern string) (*regexp.Regexp, error) {
 	regexPattern = strings.Replace(regexPattern, "*", "([^.]+)", 1)
 
 	// Allow trailing period.
-	regexPattern = regexPattern + "\\.?"
+	regexPattern += "\\.?"
 
 	// Allow optional port number.
 	regexPattern += "(:\\d+)?"
diff --git a/enterprise/coderd/license/license.go b/enterprise/coderd/license/license.go
@@ -389,7 +389,7 @@ func ParseClaimsIgnoreNbf(rawJWT string, keys map[string]ed25519.PublicKey) (*Cl
 	var vErr *jwt.ValidationError
 	if xerrors.As(err, &vErr) {
 		// zero out the NotValidYet error to check if there were other problems
-		vErr.Errors = vErr.Errors & (^jwt.ValidationErrorNotValidYet)
+		vErr.Errors &= (^jwt.ValidationErrorNotValidYet)
 		if vErr.Errors != 0 {
 			// There are other errors besides not being valid yet. We _could_ go
 			// through all the jwt.ValidationError bits and try to work out the
diff --git a/enterprise/dbcrypt/cipher_internal_test.go b/enterprise/dbcrypt/cipher_internal_test.go
@@ -59,7 +59,7 @@ func TestCipherAES256(t *testing.T) {
 
 		munged := make([]byte, len(encrypted1))
 		copy(munged, encrypted1)
-		munged[0] = munged[0] ^ 0xff
+		munged[0] ^= 0xff
 		_, err = cipher.Decrypt(munged)
 		var decryptErr *DecryptFailedError
 		require.ErrorAs(t, err, &decryptErr, "munging the first byte of the encrypted data should cause decryption to fail")

Original file line number	Diff line number	Diff line change
`@@ -1045,7 +1045,7 @@ func formatMultiError(from string, multi []error, opts *formatOpts) string {`
`1045`	`1045`	`prefix := fmt.Sprintf("%d. ", i+1)`
`1046`	`1046`	`if len(prefix) < len(indent) {`
`1047`	`1047`	`// Indent the prefix to match the indent`
`1048`		`- prefix = prefix + strings.Repeat(" ", len(indent)-len(prefix))`
	`1048`	`+ prefix += strings.Repeat(" ", len(indent)-len(prefix))`
`1049`	`1049`	`}`
`1050`	`1050`	`errStr = prefix + errStr`
`1051`	`1051`	`// Now looks like`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ func parseCLISchedule(parts ...string) (*cron.Schedule, error) {`
`167`	`167`	`func parseDuration(raw string) (time.Duration, error) {`
`168`	`168`	`// If the user input a raw number, assume minutes`
`169`	`169`	`if isDigit(raw) {`
`170`		`- raw = raw + "m"`
	`170`	`+ raw += "m"`
`171`	`171`	`}`
`172`	`172`	`d, err := time.ParseDuration(raw)`
`173`	`173`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ func convertParameterInsights(rows []database.GetTemplateParameterInsightsRow) [`
`287`	`287`	`if _, ok := m[key]; !ok {`
`288`	`288`	`m[key] = 0`
`289`	`289`	`}`
`290`		`- m[key] = m[key] + r.Count`
	`290`	`+ m[key] += r.Count`
`291`	`291`	`}`
`292`	`292`	`}`
`293`	`293`