Review comments

dannykopping · dannykopping · commit 31433920d714 · 2025-04-23T14:01:38.000+02:00
Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/codersdk/deployment.go b/codersdk/deployment.go
@@ -3038,7 +3038,6 @@ Write out the current server config as YAML to stdout.`,
 			Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),
 			Hidden:      true, // Hidden because most operators should not need to modify this.
 		},
-		// Push notifications.
 
 		// Workspace Prebuilds Options
 		{
diff --git a/enterprise/coderd/coderd.go b/enterprise/coderd/coderd.go
@@ -1152,7 +1152,13 @@ func (api *API) Authorize(r *http.Request, action policy.Action, object rbac.Obj
 func (api *API) setupPrebuilds(featureEnabled bool) (agplprebuilds.ReconciliationOrchestrator, agplprebuilds.Claimer) {
 	experimentEnabled := api.AGPL.Experiments.Enabled(codersdk.ExperimentWorkspacePrebuilds)
 	if !experimentEnabled || !featureEnabled {
-		api.Logger.Debug(context.Background(), "prebuilds not enabled",
+		levelFn := api.Logger.Debug
+		// If the experiment is enabled but the license does not entitle the feature, operators should be warned.
+		if !featureEnabled {
+			levelFn = api.Logger.Warn
+		}
+
+		levelFn(context.Background(), "prebuilds not enabled",
 			slog.F("experiment_enabled", experimentEnabled), slog.F("feature_enabled", featureEnabled))
 
 		return agplprebuilds.DefaultReconciler, agplprebuilds.DefaultClaimer

Original file line number	Diff line number	Diff line change
@@ -3038,7 +3038,6 @@ Write out the current server config as YAML to stdout.`,
`3038`	`3038`	`Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),`
`3039`	`3039`	`Hidden: true, // Hidden because most operators should not need to modify this.`
`3040`	`3040`	`},`
`3041`		`- // Push notifications.`
`3042`	`3041`
`3043`	`3042`	`// Workspace Prebuilds Options`
`3044`	`3043`	`{`