fix: custom role with no permissions

jaaydenh · jaaydenh · commit 32f74504a9b5 · 2024-08-31T00:13:57.000Z
diff --git a/site/src/pages/ManagementSettingsPage/CustomRolesPage/CustomRolesPageView.stories.tsx b/site/src/pages/ManagementSettingsPage/CustomRolesPage/CustomRolesPageView.stories.tsx
@@ -1,5 +1,8 @@
 import type { Meta, StoryObj } from "@storybook/react";
-import { MockRoleWithOrgPermissions } from "testHelpers/entities";
+import {
+	MockRoleWithOrgPermissions,
+	MockOrganizationAuditorRole,
+} from "testHelpers/entities";
 import { CustomRolesPageView } from "./CustomRolesPageView";
 
 const meta: Meta<typeof CustomRolesPageView> = {
@@ -26,6 +29,14 @@ export const Enabled: Story = {
 	},
 };
 
+export const RoleWithoutPermissions: Story = {
+	args: {
+		roles: [MockOrganizationAuditorRole],
+		canAssignOrgRole: true,
+		isCustomRolesEnabled: true,
+	},
+};
+
 export const EmptyDisplayName: Story = {
 	args: {
 		roles: [
@@ -40,15 +51,15 @@ export const EmptyDisplayName: Story = {
 	},
 };
 
-export const EmptyRoleWithoutPermission: Story = {
+export const EmptyTableUserWithoutPermission: Story = {
 	args: {
 		roles: [],
 		canAssignOrgRole: false,
 		isCustomRolesEnabled: true,
 	},
 };
 
-export const EmptyRoleWithPermission: Story = {
+export const EmptyTableUserWithPermission: Story = {
 	args: {
 		roles: [],
 		canAssignOrgRole: true,
diff --git a/site/src/pages/ManagementSettingsPage/CustomRolesPage/CustomRolesPageView.tsx b/site/src/pages/ManagementSettingsPage/CustomRolesPage/CustomRolesPageView.tsx
@@ -145,10 +145,14 @@ const RoleRow: FC<RoleRowProps> = ({ role, onDelete, canAssignOrgRole }) => {
 
 			<TableCell>
 				<Stack direction="row" spacing={1}>
-					<PermissionsPill
-						resource={resourceTypes[0]}
-						permissions={role.organization_permissions}
-					/>
+					{role.organization_permissions.length > 0 ? (
+						<PermissionsPill
+							resource={resourceTypes[0]}
+							permissions={role.organization_permissions}
+						/>
+					) : (
+						<p>None</p>
+					)}
 
 					{resourceTypes.length > 1 && (
 						<OverflowPermissionPill
