Skip to content

Commit 356db63

Browse files
committed
use CAS
1 parent 20c05f8 commit 356db63

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

provisionerd/provisionerd_test.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -221,13 +221,11 @@ func TestProvisionerd(t *testing.T) {
221221
closer := createProvisionerd(t, func(ctx context.Context) (proto.DRPCProvisionerDaemonClient, error) {
222222
return createProvisionerDaemonClient(t, provisionerDaemonTestServer{
223223
acquireJob: func(ctx context.Context, _ *proto.Empty) (*proto.AcquiredJob, error) {
224-
if didAcquireJob.Load() {
225-
completeOnce.Do(func() {
226-
close(completeChan)
227-
})
224+
if !didAcquireJob.CAS(false, true) {
225+
completeOnce.Do(func() { close(completeChan) })
228226
return &proto.AcquiredJob{}, nil
229227
}
230-
didAcquireJob.Store(true)
228+
231229
return &proto.AcquiredJob{
232230
JobId: "test",
233231
Provisioner: "someprovisioner",
@@ -325,11 +323,11 @@ func TestProvisionerd(t *testing.T) {
325323
closer := createProvisionerd(t, func(ctx context.Context) (proto.DRPCProvisionerDaemonClient, error) {
326324
return createProvisionerDaemonClient(t, provisionerDaemonTestServer{
327325
acquireJob: func(ctx context.Context, _ *proto.Empty) (*proto.AcquiredJob, error) {
328-
if didAcquireJob.Load() {
326+
if !didAcquireJob.CAS(false, true) {
329327
completeOnce.Do(func() { close(completeChan) })
330328
return &proto.AcquiredJob{}, nil
331329
}
332-
didAcquireJob.Store(true)
330+
333331
return &proto.AcquiredJob{
334332
JobId: "test",
335333
Provisioner: "someprovisioner",
@@ -395,11 +393,11 @@ func TestProvisionerd(t *testing.T) {
395393
closer := createProvisionerd(t, func(ctx context.Context) (proto.DRPCProvisionerDaemonClient, error) {
396394
return createProvisionerDaemonClient(t, provisionerDaemonTestServer{
397395
acquireJob: func(ctx context.Context, _ *proto.Empty) (*proto.AcquiredJob, error) {
398-
if didAcquireJob.Load() {
396+
if !didAcquireJob.CAS(false, true) {
399397
completeOnce.Do(func() { close(completeChan) })
400398
return &proto.AcquiredJob{}, nil
401399
}
402-
didAcquireJob.Store(true)
400+
403401
return &proto.AcquiredJob{
404402
JobId: "test",
405403
Provisioner: "someprovisioner",

0 commit comments

Comments
 (0)