Skip to content

Commit 35df01f

Browse files
committed
added checks for StartedAt value in the updated jobs
1 parent 3c7c323 commit 35df01f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

coderd/reaper/detector_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -548,6 +548,8 @@ func TestDetectorNotStartedWorkspaceBuildNoOverrideStateIfNoExistingBuild(t *tes
548548
require.WithinDuration(t, now, job.UpdatedAt, 30*time.Second)
549549
require.True(t, job.CompletedAt.Valid)
550550
require.WithinDuration(t, now, job.CompletedAt.Time, 30*time.Second)
551+
require.True(t, job.StartedAt.Valid)
552+
require.WithinDuration(t, now, job.StartedAt.Time, 30*time.Second)
551553
require.True(t, job.Error.Valid)
552554
require.Contains(t, job.Error.String, "Build has been detected as not started")
553555
require.False(t, job.ErrorCode.Valid)
@@ -750,6 +752,8 @@ func TestDetectorNotStartedOtherJobTypes(t *testing.T) {
750752
require.WithinDuration(t, now, job.UpdatedAt, 30*time.Second)
751753
require.True(t, job.CompletedAt.Valid)
752754
require.WithinDuration(t, now, job.CompletedAt.Time, 30*time.Second)
755+
require.True(t, job.StartedAt.Valid)
756+
require.WithinDuration(t, now, job.StartedAt.Time, 30*time.Second)
753757
require.True(t, job.Error.Valid)
754758
require.Contains(t, job.Error.String, "Build has been detected as not started")
755759
require.False(t, job.ErrorCode.Valid)
@@ -760,6 +764,8 @@ func TestDetectorNotStartedOtherJobTypes(t *testing.T) {
760764
require.WithinDuration(t, now, job.UpdatedAt, 30*time.Second)
761765
require.True(t, job.CompletedAt.Valid)
762766
require.WithinDuration(t, now, job.CompletedAt.Time, 30*time.Second)
767+
require.True(t, job.StartedAt.Valid)
768+
require.WithinDuration(t, now, job.StartedAt.Time, 30*time.Second)
763769
require.True(t, job.Error.Valid)
764770
require.Contains(t, job.Error.String, "Build has been detected as not started")
765771
require.False(t, job.ErrorCode.Valid)

0 commit comments

Comments
 (0)