fix git auth validation result and callback

BrunoQuaresma · BrunoQuaresma · commit 37e6dd3b4d18 · 2023-07-21T16:03:07.000Z
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -242,7 +242,8 @@ const useGitAuthVerification = (gitAuth: TypesGen.TemplateVersionGitAuth[]) => {
     }
 
     setGitAuthErrors(errors)
-    return Object.keys(errors).length > 0
+    const isValid = Object.keys(errors).length === 0
+    return isValid
   }
 
   return {
diff --git a/site/src/xServices/createWorkspace/createWorkspaceXService.ts b/site/src/xServices/createWorkspace/createWorkspaceXService.ts
@@ -120,7 +120,7 @@ export const createWorkspaceMachine =
                 const channel = watchGitAuthRefresh(() => {
                   callback("REFRESH_GITAUTH")
                 })
-                return channel.close
+                return () => channel.close()
               },
             },
           ],

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,8 @@ const useGitAuthVerification = (gitAuth: TypesGen.TemplateVersionGitAuth[]) => {`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`setGitAuthErrors(errors)`
`245`		`- return Object.keys(errors).length > 0`
	`245`	`+ const isValid = Object.keys(errors).length === 0`
	`246`	`+ return isValid`
`246`	`247`	`}`
`247`	`248`
`248`	`249`	`return {`